0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 00:03:11 -05:00
forgejo/models/migrations/v1_19
Gusted 138942c09e
[CHORE] Move test related function to own package
- Go's deadcode eliminator is quite simple, if you put a public function
in a package `aa/bb` that is used only by tests, it would still be built
if package `aa/bb` was imported. This means that if such functions use
libraries relevant only to tests that those libraries would still be
be built and increase the binary size of a Go binary.
- This is also the case with Forgejo, `models/migrations/base/tests.go`
contained functions exclusively used by tests which (skipping some steps
here) imports https://github.com/ClickHouse/clickhouse-go, which is
2MiB. The `code.gitea.io/gitea/models/migrations/base` package is
imported by `cmd/doctor` and thus the code of the clickhouse library is
also built and included in the Forgejo binary, although entirely unused
and not reachable.
- This patch moves the test-related functions to their own package, so
Go's deadcode eliminator knows not to build the test-related functions
and thus reduces the size of the Forgejo binary.
- It is not possible to move this to a `_test.go` file because Go does
not allow importing functions from such files, so any test helper
function must be in a non-test package and file.
- Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make
build`):
  - Before: 95912040 bytes (92M)
  - After: 92306888 bytes (89M)
2024-07-14 17:00:49 +02:00
..
main_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v231.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
v232.go Refactor setting.Database.UseXXX to methods (#23354) 2023-03-07 18:51:06 +08:00
v233.go Restructure webhook module (#22256) 2023-01-01 23:23:15 +08:00
v233_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v234.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v235.go Update gitea-vet to check FSFE REUSE (#22004) 2022-12-02 22:14:57 +08:00
v236.go Secrets storage with SecretKey encrypted (#22142) 2022-12-20 17:07:13 +08:00
v237.go Check primary keys for all tables and drop ForeignReference (#21721) 2022-12-23 19:35:43 +08:00
v238.go Add cron method to gc LFS MetaObjects (#22385) 2023-01-16 13:50:53 -06:00
v239.go Support scoped access tokens (#20908) 2023-01-17 15:46:03 -06:00
v240.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
v241.go Fix migration issue. (#22867) 2023-02-11 21:28:41 +00:00
v242.go Refactor setting.Database.UseXXX to methods (#23354) 2023-03-07 18:51:06 +08:00
v243.go Migration v244.go should be v243.go (#22988) 2023-02-19 09:24:23 -05:00