0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 15:53:07 -05:00
forgejo/models/migrations/v1_18
Gusted 138942c09e
[CHORE] Move test related function to own package
- Go's deadcode eliminator is quite simple, if you put a public function
in a package `aa/bb` that is used only by tests, it would still be built
if package `aa/bb` was imported. This means that if such functions use
libraries relevant only to tests that those libraries would still be
be built and increase the binary size of a Go binary.
- This is also the case with Forgejo, `models/migrations/base/tests.go`
contained functions exclusively used by tests which (skipping some steps
here) imports https://github.com/ClickHouse/clickhouse-go, which is
2MiB. The `code.gitea.io/gitea/models/migrations/base` package is
imported by `cmd/doctor` and thus the code of the clickhouse library is
also built and included in the Forgejo binary, although entirely unused
and not reachable.
- This patch moves the test-related functions to their own package, so
Go's deadcode eliminator knows not to build the test-related functions
and thus reduces the size of the Forgejo binary.
- It is not possible to move this to a `_test.go` file because Go does
not allow importing functions from such files, so any test helper
function must be in a non-test package and file.
- Reduction of size (built with `TAGS="sqlite sqlite_unlock_notify" make
build`):
  - Before: 95912040 bytes (92M)
  - After: 92306888 bytes (89M)
2024-07-14 17:00:49 +02:00
..
main_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v224.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v225.go Refactor setting.Database.UseXXX to methods (#23354) 2023-03-07 18:51:06 +08:00
v226.go Update go dev dependencies (#22064) 2022-12-08 16:21:37 +08:00
v227.go Refactor system setting (#27000) 2023-10-05 09:08:19 +08:00
v228.go Rename Sync2 -> Sync (#26479) 2023-08-13 21:17:21 +02:00
v229.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
v229_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00
v230.go Fix wrong table name (#30557) 2024-04-28 15:39:00 +02:00
v230_test.go [CHORE] Move test related function to own package 2024-07-14 17:00:49 +02:00