0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 08:06:49 -05:00
forgejo/web_src/svg
delvh 81fe5d6185
Convert <div class="button"> to <button class="button"> (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
..
fontawesome-openid.svg
fontawesome-save.svg Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
fontawesome-send.svg Replace some icons with SVG (#20741) 2022-08-10 18:30:40 +02:00
fontawesome-windows.svg
gitea-cargo.svg Add Cargo package registry (#21888) 2023-02-05 18:12:31 +08:00
gitea-chef.svg Add Chef package registry (#22554) 2023-02-06 09:49:21 +08:00
gitea-codebase.svg
gitea-composer.svg Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
gitea-conan.svg Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
gitea-conda.svg Add Conda package registry (#22262) 2023-02-01 12:30:39 -06:00
gitea-double-chevron-left.svg
gitea-double-chevron-right.svg
gitea-exclamation.svg Slightly reduce exclamation icon size (#20753) 2022-08-12 13:51:33 -04:00
gitea-git.svg
gitea-gitbucket.svg
gitea-github.svg
gitea-gitlab.svg
gitea-gogs.svg
gitea-helm.svg Add Helm Chart registry (#19406) 2022-04-19 12:55:35 -04:00
gitea-join.svg Change review buttons to icons to make space for text (#20934) 2022-08-26 18:49:40 +02:00
gitea-lock-cog.svg
gitea-lock.svg
gitea-matrix.svg Embed Matrix icon as SVG (#21890) 2022-11-21 20:25:26 +00:00
gitea-maven.svg Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
gitea-npm.svg Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
gitea-nuget.svg Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
gitea-onedev.svg
gitea-pub.svg Add support for Pub packages (#20560) 2022-08-07 18:09:54 +08:00
gitea-python.svg Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
gitea-rubygems.svg Add Package Registry (#16510) 2022-03-30 16:42:47 +08:00
gitea-split.svg Change review buttons to icons to make space for text (#20934) 2022-08-26 18:49:40 +02:00
gitea-swift.svg Add Swift package registry (#22404) 2023-03-13 15:28:39 -05:00
gitea-unlock.svg
gitea-vagrant.svg Add support for Vagrant packages (#20930) 2022-08-29 15:04:45 +08:00
gitea-vscode.svg
gitea-whitespace.svg Change review buttons to icons to make space for text (#20934) 2022-08-26 18:49:40 +02:00
material-invert-colors.svg
material-palette.svg