0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 07:43:18 -05:00
forgejo/modules
zeripath 26ef180f46
Correctly rollback in ForkRepository (#17034)
The rollback functionality in
services/repository/repository.go:ForkRepository is incorrect and could
lead to a deadlock as it uses DeleteRepository to delete the rolled-back
repository - a function which creates its own transaction.

This PR adjusts the rollback function to only use RemoveAll as any
database changes will be automatically rolled-back. It also handles
panics and adjusts the Close within WithTx to ensure that if there is a
panic the session will always be closed.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-09-14 18:16:40 +02:00
..
analyze Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
auth Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
avatar Add Image Diff for SVG files (#14867) 2021-06-05 15:32:19 +03:00
base Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
cache Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
charset Refactor renders (#15175) 2021-04-19 18:25:08 -04:00
context Add skip and limit to git.GetTags (#16897) 2021-09-10 19:30:37 +02:00
convert Support unprotected file patterns (#16395) 2021-09-11 16:21:17 +02:00
cron Refactor: Move login out of models (#16199) 2021-07-24 11:16:34 +01:00
csv Fixes #16557 - duplicate csv import (#16631) 2021-08-05 17:56:11 +01:00
doctor Fix storage Iterate bug and Add storage doctor to delete garbage attachments (#16971) 2021-09-06 16:46:20 +02:00
emoji Run processors on whole of text (#16155) 2021-06-17 11:35:05 +01:00
eventsource Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
generate switch to maintained lib (#16532) 2021-07-24 13:00:41 +02:00
git Support unprotected file patterns (#16395) 2021-09-11 16:21:17 +02:00
gitgraph Fix bug on commit graph (#15517) 2021-04-17 10:27:25 +01:00
graceful Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
hcaptcha
highlight Just use a slice when rendering file (#16774) 2021-08-23 22:23:39 +01:00
httpcache Add ETag header (#15370) 2021-04-12 10:49:26 -04:00
httplib Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
indexer Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
json Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
lfs Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
log Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
markup In Render tolerate not being passed a context (#16842) 2021-08-28 21:15:56 +01:00
matchlist
metrics Separate open and closed issue in metrics (#16637) 2021-08-07 12:43:50 +03:00
migrations Make TestOneDevDownloadRepo work again & more resistant (#16987) 2021-09-08 16:17:22 +02:00
nosql Fix setting redis db path (#15698) 2021-05-03 13:24:24 -04:00
notification Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
options Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
password Fixed assert statements. (#16089) 2021-06-07 07:27:09 +02:00
pprof
private Fix dump and restore respository (#16698) 2021-08-30 21:18:15 -04:00
process Code Formats, Nits & Unused Func/Var deletions (#15286) 2021-04-09 09:40:34 +02:00
proxy Return nil proxy function if proxy not enabled (#16742) 2021-08-19 16:41:20 -04:00
public Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
queue Use immediate queues in integration tests and ensure that immediate (#16927) 2021-09-03 11:20:57 +01:00
recaptcha Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
references Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repofiles Support unprotected file patterns (#16395) 2021-09-11 16:21:17 +02:00
repository Correctly rollback in ForkRepository (#17034) 2021-09-14 18:16:40 +02:00
secret Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
session Add an abstract json layout to make it's easier to change json library (#16528) 2021-07-24 18:03:58 +02:00
setting Enable Malayalam, Greek, Persian, Hungarian & Indonesian by default (#16998) 2021-09-09 14:16:42 +08:00
ssh Second attempt at preventing zombies (#16326) 2021-07-14 10:43:13 -04:00
storage Fix storage Iterate bug and Add storage doctor to delete garbage attachments (#16971) 2021-09-06 16:46:20 +02:00
structs Support unprotected file patterns (#16395) 2021-09-11 16:21:17 +02:00
svg Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
sync
task Fix bug of migrated repository not index (#16991) 2021-09-08 18:43:19 +01:00
templates Add missing icon set for ActionRenameRepo (#16972) 2021-09-06 16:11:17 +02:00
test
timeutil
translation Use index of the supported tags to choose user lang (#15452) 2021-04-14 19:52:01 +01:00
typesniffer Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
upload
uri
user
util Handle too long PR titles correctly (#16517) 2021-07-25 03:59:27 +01:00
validation Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
web Restore CORS on git smart http protocol (#16496) 2021-07-21 11:32:35 +08:00