0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-01-07 23:20:48 -05:00
forgejo/modules
zeripath 6986e56791
Stop logging EOFs and exit(1)s in ssh handler (#20476) (#20529)
Backport #20476

The code in modules/ssh/ssh.go:sessionHandler() currently cause an error to be
logged if `gitea serv` exits with a exit(1). This logging is useless because the
accompanying stderr is not provided and in any case the exit(1) is most likely due
to permissions errors.

Further it then causes the EOF to be logged - even though this is not helpful.

This PR simply checks the errors returned and stops logging them.

In the case of misconfigurations causing `gitea serv` to fail with exit(1)
the current logging is not helpful at determining this and users should simply
review the message passed over the ssh connection.

Fix #20473

Signed-off-by: Andrew Thornton <art27@cantab.net>
2022-07-29 02:10:42 +02:00
..
activitypub
analyze Simplify IsVendor (#19626) 2022-05-06 10:12:30 +01:00
appstate
auth Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
avatar Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
base Prettify number of issues (#17760) 2022-06-12 20:08:23 +08:00
cache Update go-chi/cache to utilize Ping() (#19719) 2022-05-15 20:43:27 +02:00
charset Detect truncated utf-8 characters at the end of content as still representing utf-8 (#19773) 2022-05-21 14:06:24 +01:00
container
context Fix package permission checks for organizations (#20517) (#20520) 2022-07-28 22:05:59 +08:00
convert Move issues related files into models/issues (#19931) 2022-06-13 17:37:59 +08:00
csv Allow render HTML with css/js external links (#19017) 2022-06-16 11:33:23 +08:00
doctor Backtick table name in generic orphan check (#20019) (#20037) 2022-06-19 19:41:12 +01:00
emoji
eventsource Stop spurious APIFormat stopwatches logs (#20008) 2022-06-17 22:47:15 +01:00
generate
git Fix commit status icon when in subdirectory (#20285) (#20385) 2022-07-16 14:54:49 +02:00
gitgraph Move some code into models/git (#19879) 2022-06-12 23:51:54 +08:00
graceful Fix signal loop in graceful manager (#19943) 2022-06-12 21:50:18 +08:00
hcaptcha
highlight Fix copy/paste of empty lines (#19798) 2022-06-10 21:45:28 +08:00
hostmatcher Support hostname:port to pass host matcher's check #19543 (#19543) 2022-04-29 01:39:50 +08:00
httpcache Add Cache-Control header to html and api responses, add no-transform (#20432) (#20459) 2022-07-23 11:58:58 +01:00
httplib
indexer Fix dump-repo git init, fix wrong error type for NullDownloader (#20182) (#20186) 2022-07-01 18:01:05 +02:00
json
lfs Move some code into models/git (#19879) 2022-06-12 23:51:54 +08:00
log Empty log queue on flush and close (#19994) 2022-06-18 10:33:13 +08:00
markup Fix NPE when using non-numeric (#20277) (#20278) 2022-07-07 20:56:50 +08:00
metrics
migration Fix dump-repo git init, fix wrong error type for NullDownloader (#20182) (#20186) 2022-07-01 18:01:05 +02:00
nosql
notification Move issues related files into models/issues (#19931) 2022-06-13 17:37:59 +08:00
options Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
packages Allow non-semver packages in the Conan package registry (#20412) (#20523) 2022-07-28 21:19:56 +01:00
paginator
password
pprof
private
process Set Setpgid on child git processes (#19865) 2022-06-03 15:36:18 +01:00
proxy
public Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
queue Fix 64-bit atomic operations on 32-bit machines (#19531) 2022-04-27 10:32:04 -05:00
recaptcha
references Custom regexp external issues (#17624) 2022-06-10 13:39:53 +08:00
regexplru Custom regexp external issues (#17624) 2022-06-10 13:39:53 +08:00
repository Remove legacy git code (ver < 2.0), fine tune markup tests (#19930) 2022-06-16 23:47:44 +08:00
secret
session
setting Allow RSA 2047 bit keys (#20272) (#20396) 2022-07-18 10:30:01 -04:00
ssh Stop logging EOFs and exit(1)s in ssh handler (#20476) (#20529) 2022-07-29 02:10:42 +02:00
storage
structs Dismiss prior pull reviews if done via web in review dismiss (#20197) (#20407) 2022-07-19 17:46:33 +02:00
svg Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
sync Use queue instead of memory queue in webhook send service (#19390) 2022-04-25 20:03:01 +02:00
templates fix push mirrors URL are no longer displayed on the UI (#20011) 2022-06-18 11:30:26 +08:00
test Move access and repo permission to models/perm/access (#19350) 2022-05-11 12:09:36 +02:00
timeutil
translation
typesniffer Fix raw endpoint PDF file headers (#19825) 2022-05-28 18:10:14 +03:00
updatechecker
upload
uri
user
util Prettify number of issues (#17760) 2022-06-12 20:08:23 +08:00
validation use IsLoopback (#19477) 2022-04-25 13:55:12 +08:00
web Unify repo settings & show better error (#19828) 2022-06-12 13:43:27 +08:00