0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-25 17:04:12 -05:00
forgejo/routers/web/user/setting
M Hickford 191a74d622
Record OAuth client type at registration (#21316)
The OAuth spec [defines two types of
client](https://datatracker.ietf.org/doc/html/rfc6749#section-2.1),
confidential and public. Previously Gitea assumed all clients to be
confidential.

> OAuth defines two client types, based on their ability to authenticate
securely with the authorization server (i.e., ability to
>   maintain the confidentiality of their client credentials):
>
>   confidential
> Clients capable of maintaining the confidentiality of their
credentials (e.g., client implemented on a secure server with
> restricted access to the client credentials), or capable of secure
client authentication using other means.
>
>   **public
> Clients incapable of maintaining the confidentiality of their
credentials (e.g., clients executing on the device used by the resource
owner, such as an installed native application or a web browser-based
application), and incapable of secure client authentication via any
other means.**
>
> The client type designation is based on the authorization server's
definition of secure authentication and its acceptable exposure levels
of client credentials. The authorization server SHOULD NOT make
assumptions about the client type.

 https://datatracker.ietf.org/doc/html/rfc8252#section-8.4

> Authorization servers MUST record the client type in the client
registration details in order to identify and process requests
accordingly.

Require PKCE for public clients:
https://datatracker.ietf.org/doc/html/rfc8252#section-8.1

> Authorization servers SHOULD reject authorization requests from native
apps that don't use PKCE by returning an error message

Fixes #21299

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2022-10-24 15:59:24 +08:00
..
security Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
account.go Added email notification option to receive all own messages (#20179) 2022-07-28 16:30:12 +08:00
account_test.go Update HTTP status codes to modern codes (#18063) 2022-03-23 12:54:07 +08:00
adopt.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
applications.go Move some files into models' sub packages (#20262) 2022-08-25 10:31:57 +08:00
keys.go Use ctx instead of db.DefaultContext in some packages(routers/services/modules) (#19163) 2022-03-22 16:22:54 +01:00
main_test.go Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
oauth2.go Allow creation of OAuth2 applications for orgs (#18084) 2022-10-09 20:07:41 +08:00
oauth2_common.go Record OAuth client type at registration (#21316) 2022-10-24 15:59:24 +08:00
profile.go Add Docker /v2/_catalog endpoint (#20469) 2022-07-28 11:59:39 +08:00