0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 23:33:15 -05:00
forgejo/services/context
oliverpool 16879b07d2 [PORT] drop utils.IsExternalURL (and expand IsRiskyRedirectURL tests) (#3167)
Related to  #2773
Related to Refactor URL detection [gitea#29960](https://github.com/go-gitea/gitea/pull/29960)
Related to Refactor external URL detection [gitea#29973](https://github.com/go-gitea/gitea/pull/29973)

I added a bunch of tests to `httplib.TestIsRiskyRedirectURL` and some cases should be better handled (however it is not an easy task).

I also ported the removal of `utils.IsExternalURL`, since it prevents duplicated (subtle) code.

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/3167
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-04-15 13:03:08 +00:00
..
upload Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
access_log.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
api.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
api_org.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
api_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
base.go implement fix 2024-03-07 10:53:43 +01:00
base_test.go Use strict protocol check when redirect (#29642) 2024-03-11 23:36:59 +07:00
captcha.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
context.go Customizable "Open with" applications for repository clone (#29320) 2024-03-23 11:58:54 +01:00
context_cookie.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
context_model.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
context_request.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
context_response.go [PORT] drop utils.IsExternalURL (and expand IsRiskyRedirectURL tests) (#3167) 2024-04-15 13:03:08 +00:00
context_template.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
context_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
csrf.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
org.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
package.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
pagination.go Unify search boxes (#29530) 2024-03-20 12:31:05 +00:00
permission.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
private.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
repo.go Move get/set default branch from git package to gitrepo package to hide repopath (#29126) 2024-03-11 23:36:59 +07:00
response.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
user.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
utils.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
xsrf.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00
xsrf_test.go Move context from modules to services (#29440) 2024-03-06 12:10:43 +08:00