Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 08:06:49 -05:00
Code Issues Activity
forgejo/modules/git
History
zeripath 0faf175694
Fix missing close in WalkGitLog (#17008) 
When the external context is cancelled it is possible for the
GitLogReader to not itself be Closed.

This PR does three things:

1. Instead of adding a plain defer it wraps the `g.Close` in a func as
`g` may change.
2. It adds the missing explicit g.Close - although the defer fix makes
this unnecessary.
3. It passes down the external context as the base context for the
GitLogReader meaning that the cancellation of the external context will
pass down automatically.

Fix #17007

Signed-off-by: Andrew Thornton <art27@cantab.net>
2021-09-10 17:46:12 +08:00
..
pipeline Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tests/repos Fix webhook commits wrong hash on HEAD reset (#16283) 2021-06-30 19:49:06 +02:00
batch_reader.go Make cancel from CatFileBatch and CatFileBatchCheck wait for the command to end (#16479) 2021-07-20 20:23:01 +03:00
blame.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
blame_test.go
blob.go Fix diff expansion is missing final line in a file (#16222) 2021-06-24 17:47:46 +02:00
blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
blob_nogogit.go Fix git.Blob.DataAsync(): close pipe since we return a NopCloser (#16899) 2021-08-31 08:43:31 +01:00
blob_test.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
command.go Add proxy settings and support for migration and webhook (#16704) 2021-08-18 21:10:39 +08:00
command_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
commit_convert_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit_info.go
commit_info_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit_info_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
commit_info_test.go Make commit info cancelable (#16032) 2021-06-06 19:44:58 -04:00
commit_reader.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
commit_test.go Fix modified files list in webhooks when there is a space (#16288) 2021-07-02 21:23:37 +02:00
diff.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
diff_test.go Fix a couple of CommentAsPatch issues. (#14804) 2021-02-27 19:46:14 +01:00
error.go Fix 500 Error with branch and tag sharing the same name #15592 (#16040) 2021-06-23 17:08:26 -04:00
git.go Add agit flow support in gitea (#14295) 2021-07-28 17:42:56 +08:00
git_test.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
hook.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
last_commit_cache.go Use gitea logging module for git module (#16243) 2021-06-25 17:54:08 +01:00
last_commit_cache_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
last_commit_cache_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
lfs.go Let package git depend on setting but not opposite (#15241) 2021-06-26 13:28:55 +02:00
log_name_status.go Fix missing close in WalkGitLog (#17008) 2021-09-10 17:46:12 +08:00
notes.go
notes_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
notes_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
notes_test.go Change the implementation of the go-git version of GetNote to mirror the non go-git version when passed a non-existent commit (#16658) 2021-08-09 16:24:34 +01:00
parse_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_gogit_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
parse_nogogit_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
README.md
ref.go
remote.go Add push to remote mirror repository (#15157) 2021-06-14 19:20:43 +02:00
repo.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_archive.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_attribute.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_attribute_test.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_base_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_base_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blame.go
repo_blob.go
repo_blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blob_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_blob_test.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
repo_branch.go Add agit flow support in gitea (#14295) 2021-07-28 17:42:56 +08:00
repo_branch_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_branch_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_branch_test.go [API] Add pagination to ListBranches (#14524) 2021-02-03 20:06:13 +01:00
repo_commit.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
repo_commit_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_commit_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_commit_test.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
repo_commitgraph_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_compare.go Replace list.List with slices (#16311) 2021-08-09 14:08:51 -04:00
repo_compare_test.go
repo_gpg.go
repo_hook.go
repo_index.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_language_stats.go
repo_language_stats_gogit.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_language_stats_nogogit.go Use git attributes to determine generated and vendored status for language stats and diffs (#16773) 2021-09-09 21:13:36 +01:00
repo_object.go
repo_ref.go
repo_ref_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_ref_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_ref_test.go
repo_stats.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
repo_stats_test.go
repo_tag.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
repo_tag_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_tag_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_tag_test.go [API] generalize list header (#16551) 2021-08-12 14:43:08 +02:00
repo_test.go Tests should use test files (#15801) 2021-05-09 17:20:33 +02:00
repo_tree.go
repo_tree_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
repo_tree_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
sha1.go
sha1_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
sha1_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
signature.go
signature_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
signature_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
submodule.go
submodule_test.go
tag.go Tagger can be empty, as can Commit and Author - tolerate this (#15835) 2021-05-12 01:11:42 -04:00
tag_test.go
tree.go Add TestPrepareWikiFileName (#16487) 2021-07-20 15:16:20 +02:00
tree_blob.go
tree_blob_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_blob_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry.go On open repository open common cat file batch and batch-check (#15667) 2021-05-10 03:27:03 +02:00
tree_entry_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry_mode.go
tree_entry_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_entry_test.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_gogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
tree_nogogit.go Add bundle download for repository (#14538) 2021-08-24 11:47:09 -05:00
utils.go Fix various documentation, user-facing, and source comment typos (#16367) 2021-07-08 13:38:13 +02:00
utils_test.go

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.