0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-23 15:53:07 -05:00
forgejo/modules
JonRB cb37c6ba5c
call builtinUnused() if internal SSH is disabled (#20877)
The graceful manager waits for 4 listeners to be created or to be told that they are not needed. If it is not told about them it will indefinitely and timeout. 

This leads to SVC hosts not being told of being in the readyState but on Unix would lead to the termination of the process.

There was an unfortunate regression in #20299 which missed this subtly and in the case whereby SSH is disabled the `builtinUnused()` is not called.

This PR adds a call to `builtinUnused()` when not using the builtin ssh to allow `createServerWaitGroup.Done()` to be called. 

In addition it was noted that the if/else clauses for timeout informing of the SVC host were in the wrong order. These have been swapped.

Fix #20609
2022-08-20 22:09:41 +01:00
..
activitypub Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
analyze Simplify IsVendor (#19626) 2022-05-06 10:12:30 +01:00
appstate Use a struct as test options (#19393) 2022-04-14 21:58:21 +08:00
auth Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
avatar Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
base Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
cache Update go-chi/cache to utilize Ping() (#19719) 2022-05-15 20:43:27 +02:00
charset Switch Unicode Escaping to a VSCode-like system (#19990) 2022-08-13 19:32:34 +01:00
container Move reaction to models/issues/ (#19264) 2022-03-31 17:20:39 +08:00
context Fix disable download button (#20701) 2022-08-08 15:42:36 +02:00
convert Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
csv Allow render HTML with css/js external links (#19017) 2022-06-16 11:33:23 +08:00
doctor Fix git.Init for doctor sub-command (#20782) 2022-08-14 00:33:18 +08:00
emoji
eventsource Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
generate
git Remove follow from commits by file (#20765) 2022-08-14 21:22:13 -04:00
gitgraph Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
graceful call builtinUnused() if internal SSH is disabled (#20877) 2022-08-20 22:09:41 +01:00
hcaptcha
highlight Rework file highlight rendering and fix yaml copy-paste (#19967) 2022-07-30 21:17:43 +02:00
hostmatcher Add proxy host into allow list (#20798) 2022-08-16 20:15:54 -04:00
httpcache Add Cache-Control header to html and api responses, add no-transform (#20432) 2022-07-23 14:38:03 +08:00
httplib
indexer Fix dump-repo git init, fix wrong error type for NullDownloader (#20182) 2022-07-01 07:48:25 +08:00
json Refactor legacy unknwon/com package, improve golangci lint (#19284) 2022-04-01 16:47:50 +08:00
lfs Removed some vestigial code related to Range bounds checks (#20312) 2022-07-28 11:04:36 +08:00
log Disable doctor logging on panic (#20847) 2022-08-18 21:27:27 -04:00
markup Should also support upper-case README files (#20581) 2022-08-01 20:15:40 +08:00
mcaptcha Add support mCaptcha as captcha provider (#20458) 2022-08-10 15:20:10 +02:00
metrics
migration Fix dump-repo git init, fix wrong error type for NullDownloader (#20182) 2022-07-01 07:48:25 +08:00
mirror Implement sync push mirror on commit (#19411) 2022-07-08 20:45:12 +01:00
nosql Fix various typos (#20338) 2022-07-12 23:32:37 +02:00
notification Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
options Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
packages Add migrate repo archiver and packages storage support on command line (#20757) 2022-08-16 12:05:15 +08:00
paginator Remove legacy unmaintained packages, refactor to support change default locale (#19308) 2022-04-03 17:46:48 +08:00
password
pprof
private Allow manager logging to set SQL (#20064) 2022-06-24 12:49:47 +02:00
process Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
proxy
public Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
queue Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
recaptcha
references Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
regexplru Custom regexp external issues (#17624) 2022-06-10 13:39:53 +08:00
repository Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
secret
session
setting auth/reverseproxy: Add support for full name (#20776) 2022-08-16 14:30:27 +08:00
sitemap Add sitemap support (#18407) 2022-06-25 19:06:01 +02:00
ssh call builtinUnused() if internal SSH is disabled (#20877) 2022-08-20 22:09:41 +01:00
storage Add more linters to improve code readability (#19989) 2022-06-20 12:02:49 +02:00
structs Add new API endpoints for push mirrors management (#19841) 2022-07-30 18:45:59 +02:00
svg Remove legacy +build: constraint (#19582) 2022-05-02 23:22:45 +08:00
sync Use queue instead of memory queue in webhook send service (#19390) 2022-04-25 20:03:01 +02:00
templates Don't open new page for ext wiki on same repository (#20725) 2022-08-20 15:47:04 +01:00
test Refactor AssertExistsAndLoadBean to use generics (#20797) 2022-08-16 10:22:25 +08:00
timeutil Remove useless JS operation for relative time tooltips (#20756) 2022-08-12 17:03:41 -04:00
translation Allow dev i18n to be more concurrent (#20159) 2022-07-04 12:17:09 +02:00
typesniffer Rework raw file http header logic (#20484) 2022-07-29 17:26:55 +02:00
updatechecker
upload
uri
user
util Fix SecToTime edge-cases (#20610) 2022-08-08 13:07:42 +08:00
validation use IsLoopback (#19477) 2022-04-25 13:55:12 +08:00
web refactor webhook *NewPost (#20729) 2022-08-11 17:48:23 +02:00