0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-01-09 16:10:50 -05:00
forgejo/services/repository
oliverpool 07bc099401 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 14:06:43 +01:00
..
archiver
files [BUG] split code conversations in diff tab (#2306) 2024-02-16 14:06:43 +01:00
adopt.go Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
adopt_test.go
avatar.go
avatar_test.go
branch.go services: Gracefully handle missing branches 2024-01-15 00:15:12 +01:00
cache.go
check.go
collaboration.go Fix DeleteCollaboration transaction behaviour (#28886) (#28889) 2024-01-31 14:18:26 +01:00
collaboration_test.go
commit.go
create.go
create_test.go
delete.go Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
delete_test.go Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
fork.go
fork_test.go
hooks.go
lfs.go
lfs_test.go Delete repos of org when purge delete user (#27273) (#27728) 2023-11-01 10:03:12 +08:00
main_test.go
push.go Also sync DB branches on push if necessary (#28361) (#28403) 2023-12-12 15:21:33 +01:00
repository.go
repository_test.go
review.go
review_test.go
template.go
transfer.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00
transfer_test.go [MODERATION] User blocking 2023-11-13 13:58:02 +01:00