0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-24 08:06:49 -05:00
forgejo/routers/repo
zeripath 01c10a951b
Fix ssh deploy and user key constraints (#1357) (#5939)
1. A key can either be an ssh user key or a deploy key. It cannot be both.
2. If a key is a user key - it can only be associated with one user.
3. If a key is a deploy key - it can be used in multiple repositories and the permissions it has on those repositories can be different.
4. If a repository is deleted, its deploy keys must be deleted too.

We currently don't enforce any of this and multiple repositories access with different permissions doesn't work at all. This PR enforces the following constraints:

- [x] You should not be able to add the same user key as another user
- [x] You should not be able to add a ssh user key which is being used as a deploy key
- [x] You should not be able to add a ssh deploy key which is being used as a user key
- [x] If you add an ssh deploy key to another repository you should be able to use it in different modes without losing the ability to use it in the other mode.
- [x] If you delete a repository you must delete all its deploy keys.

Fix #1357
2019-02-03 23:56:53 +00:00
..
activity.go Restrict permission check on repositories and fix some problems (#5314) 2018-11-28 19:26:14 +08:00
attachment.go
branch.go branch: Trigger update when deleting branch via UI. (#5617) 2019-01-02 20:56:58 +08:00
commit.go fix commit page showing status for current default branch (#5650) 2019-01-06 16:32:00 +02:00
download.go Add raw blob endpoint to get objects by SHA ID (#5334) 2018-11-18 13:45:40 -05:00
editor.go SECURITY: protect DeleteFilePost et al with cleanUploadFileName (#5631) 2019-01-04 11:08:26 -05:00
editor_test.go fix bug on upload file name (#5571) 2018-12-20 21:32:11 -05:00
http.go Feature: Archive repos (#5009) 2019-01-23 13:58:38 -05:00
issue.go New Issue ?body= query (#5851) 2019-01-28 10:23:59 -05:00
issue_dependency.go Added dependencies for issues (#2196) (#2531) 2018-07-17 17:23:58 -04:00
issue_label.go Add label descriptions (#3662) 2018-03-13 10:03:55 +08:00
issue_label_test.go fix go vet error (#3740) 2018-03-30 07:21:27 +08:00
issue_stopwatch.go
issue_timetrack.go
issue_watch.go Restrict permission check on repositories and fix some problems (#5314) 2018-11-28 19:26:14 +08:00
main_test.go
middlewares.go Add whitespace handling to PR-comparsion (#4683) 2018-08-14 13:49:33 -04:00
milestone.go Issue is not overdue when it is on the same date #5566 (#5568) 2019-01-01 18:56:47 +01:00
pull.go Disallow empty titles (#5785) 2019-01-21 13:45:32 +02:00
pull_review.go Add comment replies (#5104) 2018-10-22 16:13:35 -04:00
release.go Feature: Archive repos (#5009) 2019-01-23 13:58:38 -05:00
release_test.go
repo.go Refactor repo.isBare to repo.isEmpty #5629 (#5714) 2019-01-17 19:01:04 -05:00
search.go Global code search support (#3664) 2018-03-16 22:04:33 +08:00
setting.go Fix ssh deploy and user key constraints (#1357) (#5939) 2019-02-03 23:56:53 +00:00
setting_protected_branch.go Approvals at Branch Protection (#5350) 2018-12-11 19:28:37 +08:00
settings_test.go An inactive user shouldn't be able to be added as a collaborator (#4535) 2018-08-07 13:01:06 +03:00
topic.go Fix topics addition (Another solution) (#4031) (#4258) 2018-06-21 17:09:46 +08:00
view.go Feature: Archive repos (#5009) 2019-01-23 13:58:38 -05:00
webhook.go Slack webhook channel name cannot be empty or just contain an hashtag (#4786) 2018-09-10 10:31:08 -04:00
wiki.go Feature: Archive repos (#5009) 2019-01-23 13:58:38 -05:00
wiki_test.go