From b7b52fd04d80c3ad55d9c7f05374396b8adb7ab5 Mon Sep 17 00:00:00 2001 From: Gusted Date: Thu, 30 Jan 2025 12:16:12 +0100 Subject: [PATCH] chore: Remove `ChangeProjectStatus` - Introduced in 4027c5dd7c11c1256094e202be591ec1b86a011e and removed in the same commit (only used for testing code). --- .deadcode-out | 3 --- models/project/project.go | 15 --------------- models/project/project_test.go | 2 +- 3 files changed, 1 insertion(+), 19 deletions(-) diff --git a/.deadcode-out b/.deadcode-out index 3bf759ffe0..7f8ba47e2a 100644 --- a/.deadcode-out +++ b/.deadcode-out @@ -60,9 +60,6 @@ code.gitea.io/gitea/models/organization code.gitea.io/gitea/models/perm/access GetRepoWriters -code.gitea.io/gitea/models/project - ChangeProjectStatus - code.gitea.io/gitea/models/repo WatchRepoMode diff --git a/models/project/project.go b/models/project/project.go index beffffcdfc..6c2b02487d 100644 --- a/models/project/project.go +++ b/models/project/project.go @@ -368,21 +368,6 @@ func ChangeProjectStatusByRepoIDAndID(ctx context.Context, repoID, projectID int return committer.Commit() } -// ChangeProjectStatus toggle a project between opened and closed -func ChangeProjectStatus(ctx context.Context, p *Project, isClosed bool) error { - ctx, committer, err := db.TxContext(ctx) - if err != nil { - return err - } - defer committer.Close() - - if err := changeProjectStatus(ctx, p, isClosed); err != nil { - return err - } - - return committer.Commit() -} - func changeProjectStatus(ctx context.Context, p *Project, isClosed bool) error { p.IsClosed = isClosed p.ClosedDateUnix = timeutil.TimeStampNow() diff --git a/models/project/project_test.go b/models/project/project_test.go index 8c660b929a..cef2ea17bd 100644 --- a/models/project/project_test.go +++ b/models/project/project_test.go @@ -75,7 +75,7 @@ func TestProject(t *testing.T) { assert.Equal(t, project.Title, projectFromDB.Title) - require.NoError(t, ChangeProjectStatus(db.DefaultContext, project, true)) + require.NoError(t, ChangeProjectStatusByRepoIDAndID(db.DefaultContext, project.RepoID, project.ID, true)) // Retrieve from DB afresh to check if it is truly closed projectFromDB, err = GetProjectByID(db.DefaultContext, project.ID)