From 93f84db542dd8c6e952c8130bc2fcbe2e299b8b4 Mon Sep 17 00:00:00 2001 From: shgew Date: Fri, 7 Feb 2025 12:30:25 +0000 Subject: [PATCH] fix(ui): display verified icon for default gpg key (#6803) I noticed that the icon next to the GPG key reference appears to be incorrect for commits signed by the default GPG key. Looking into the commit history of the template file, I noticed that Forgejo-signed commits originally had a distinct icon: gitea-unlock-cog --> octicon-shield-lock --> octicon-unverified (current) Since octicon-unverified is also used when a commit cannot be verified (.Verification.Warning), I find it misleading for successfully signed commits. This PR changes the icon to the verified variant for better clarity. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/6803 Reviewed-by: Gusted Reviewed-by: Otto Co-authored-by: shgew Co-committed-by: shgew --- templates/repo/commit_page.tmpl | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/templates/repo/commit_page.tmpl b/templates/repo/commit_page.tmpl index 36de789dd1..7bc6dd1c97 100644 --- a/templates/repo/commit_page.tmpl +++ b/templates/repo/commit_page.tmpl @@ -217,8 +217,8 @@
{{if .Verification.Verified}} + {{svg "octicon-verified" 16 "tw-mr-2"}} {{if ne .Verification.SigningUser.ID 0}} - {{svg "octicon-verified" 16 "tw-mr-2"}} {{if .Verification.SigningSSHKey}} {{ctx.Locale.Tr "repo.commits.ssh_key_fingerprint"}}: {{.Verification.SigningSSHKey.Fingerprint}} @@ -227,7 +227,6 @@ {{.Verification.SigningKey.PaddedKeyID}} {{end}} {{else}} - {{svg "octicon-unverified" 16 "tw-mr-2"}} {{if .Verification.SigningSSHKey}} {{ctx.Locale.Tr "repo.commits.ssh_key_fingerprint"}}: {{.Verification.SigningSSHKey.Fingerprint}}