Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2025-02-22 05:46:12 -05:00
Code Issues Activity

Remove jQuery AJAX from the archive download links (#29380)

Browse source 
- Removed all jQuery AJAX calls and replaced with our fetch wrapper
- Tested the repo archive download links dropdown functionality and it
works as before

# Demo using `fetch` instead of jQuery AJAX

![action](https://github.com/go-gitea/gitea/assets/20454870/db791249-bca1-4d22-ac5e-623f68023e15)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
(cherry picked from commit ed3892d8430652c2bc8e2af21844d14769825e8a)
This commit is contained in:
Yarden Shoham 2024-02-25 18:53:44 +02:00 • committed by Earl Warren
parent cfda925862
commit 8a25361d9a
No known key found for this signature in database
GPG key ID: 0579CB2928A78A00
1 changed files with 27 additions and 31 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

58
web_src/js/features/repo-common.js
View file

@ -1,38 +1,34 @@
import $ from 'jquery'; import $ from 'jquery';
import {hideElem, showElem} from '../utils/dom.js'; import {hideElem, showElem} from '../utils/dom.js';
import {POST} from '../modules/fetch.js';
const {csrfToken} = window.config; async function getArchive($target, url, first) {
try {
function getArchive($target, url, first) { const response = await POST(url);
$.ajax({ if (response.status === 200) {
url, const data = await response.json();
type: 'POST', if (!data) {
data: { // XXX Shouldn't happen?
_csrf: csrfToken, $target.closest('.dropdown').children('i').removeClass('loading');
}, return;
complete(xhr) {
if (xhr.status === 200) {
if (!xhr.responseJSON) {
// XXX Shouldn't happen?
$target.closest('.dropdown').children('i').removeClass('loading');
return;
}
if (!xhr.responseJSON.complete) {
$target.closest('.dropdown').children('i').addClass('loading');
// Wait for only three quarters of a second initially, in case it's
// quickly archived.
setTimeout(() => {
getArchive($target, url, false);
}, first ? 750 : 2000);
} else {
// We don't need to continue checking.
$target.closest('.dropdown').children('i').removeClass('loading');
window.location.href = url;
}
} }
},
}); if (!data.complete) {
$target.closest('.dropdown').children('i').addClass('loading');
// Wait for only three quarters of a second initially, in case it's
// quickly archived.
setTimeout(() => {
getArchive($target, url, false);
}, first ? 750 : 2000);
} else {
// We don't need to continue checking.
$target.closest('.dropdown').children('i').removeClass('loading');
window.location.href = url;
}
}
} catch {
$target.closest('.dropdown').children('i').removeClass('loading');
}
} }
export function initRepoArchiveLinks() { export function initRepoArchiveLinks() {