0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-25 08:54:17 -05:00

[GITEA] Use join for the deleting issue actions query

- The action tables can become very large as it's a dumpster for every
action that an user does on an repository.
- The following query: `DELETE FROM action WHERE comment_id IN (SELECT id FROM comment WHERE
issue_id=?)` is not using indexes for `comment_id` and is instead using
an full table scan by MariaDB.
- Rewriting the query to use an JOIN will allow MariaDB to use the
index.
- More information: https://codeberg.org/Codeberg-Infrastructure/techstack-support/issues/9
This commit is contained in:
Gusted 2023-07-29 16:59:23 +02:00 committed by Gusted
parent 50b8cc3bbc
commit 6646fcf31f
6 changed files with 45 additions and 7 deletions

View file

@ -687,12 +687,22 @@ func NotifyWatchersActions(acts []*Action) error {
// DeleteIssueActions delete all actions related with issueID
func DeleteIssueActions(ctx context.Context, repoID, issueID int64) error {
// delete actions assigned to this issue
subQuery := builder.Select("`id`").
From("`comment`").
// MySQL doesn't use the indexes on comment_id when using a subquery.
// It does uses the indexes when using an JOIN, however SQLite doesn't
// allow JOINs in DELETE statements and XORM doesn't allow them as well.
// So, an specific raw SQL query for MySQL so the query makes use of indexes.
if setting.Database.Type.IsMySQL() {
if _, err := db.GetEngine(ctx).Exec("DELETE action FROM action JOIN comment ON action.comment_id = comment.id WHERE comment.issue_id = ?", issueID); err != nil {
return err
}
} else {
subQuery := builder.Select("`id`").From("`comment`").
Where(builder.Eq{"`issue_id`": issueID})
if _, err := db.GetEngine(ctx).In("comment_id", subQuery).Delete(&Action{}); err != nil {
return err
}
}
_, err := db.GetEngine(ctx).Table("action").Where("repo_id = ?", repoID).
In("op_type", ActionCreateIssue, ActionCreatePullRequest).

View file

@ -242,6 +242,15 @@ func TestGetFeedsCorrupted(t *testing.T) {
assert.Equal(t, int64(0), count)
}
func TestDeleteIssueActions(t *testing.T) {
assert.NoError(t, unittest.PrepareTestDatabase())
comment := unittest.AssertExistsAndLoadBean(t, &issue_model.Comment{ID: 8})
unittest.AssertExistsAndLoadBean(t, &activities_model.Action{ID: 10, CommentID: comment.ID})
assert.NoError(t, activities_model.DeleteIssueActions(db.DefaultContext, 32, 17))
unittest.AssertNotExistsBean(t, &activities_model.Action{ID: 10, CommentID: comment.ID})
}
func TestConsistencyUpdateAction(t *testing.T) {
if !setting.Database.Type.IsSQLite3() {
t.Skip("Test is only for SQLite database.")

View file

@ -73,3 +73,13 @@
is_private: false
created_unix: 1680454039
content: '4|' # issueId 5
- id: 10
user_id: 15
op_type: 10 # issue comment
act_user_id: 15
repo_id: 32 # public
comment_id: 8
is_private: false
created_unix: 1680454039
content: '2|meh...' # issueId 5

View file

@ -66,3 +66,12 @@
tree_path: "README.md"
created_unix: 946684812
invalidated: true
-
id: 8
type: 0 # comment
poster_id: 15
issue_id: 17 # in repo_id 32
content: "meh..."
created_unix: 946684812
updated_unix: 946684812

View file

@ -283,7 +283,7 @@
priority: 0
is_closed: false
is_pull: false
num_comments: 0
num_comments: 1
created_unix: 1602935696
updated_unix: 1602935696
is_locked: false

View file

@ -33,6 +33,6 @@ func TestNodeinfo(t *testing.T) {
assert.Equal(t, "gitea", nodeinfo.Software.Name)
assert.Equal(t, 25, nodeinfo.Usage.Users.Total)
assert.Equal(t, 18, nodeinfo.Usage.LocalPosts)
assert.Equal(t, 2, nodeinfo.Usage.LocalComments)
assert.Equal(t, 3, nodeinfo.Usage.LocalComments)
})
}