Infrastructure/forgejo
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-12-22 23:33:15 -05:00
Code Issues Activity

Do not call nil handler for a dummy queue (#24880)

Browse source 
A dummy queue doesn't really have a handler (see line 211), so the
`safeHandler` can safely drop all items
This commit is contained in:
wxiaoguang 2023-05-23 19:40:55 +08:00 committed by GitHub
parent cfadb1901f
commit 16a766cba1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
modules/queue/workerqueue.go
View file

@ -239,7 +239,10 @@ func NewWorkerPoolQueueBySetting[T any](name string, queueSetting setting.QueueS
log.Error("Recovered from panic in queue %q handler: %v\n%s", name, err, log.Stack(2)) log.Error("Recovered from panic in queue %q handler: %v\n%s", name, err, log.Stack(2))
} }
}() }()
return w.origHandler(t...) if w.origHandler != nil {
return w.origHandler(t...)
}
return nil
} }
return &w, nil return &w, nil