From 039a679ccb4cf192148a8db364932bdb7762ac91 Mon Sep 17 00:00:00 2001 From: Gusted Date: Fri, 31 Jan 2025 14:30:23 +0100 Subject: [PATCH] chore: Remove `IsCommitStatusContextSuccess` - Introduced in 04ca7f004710de2b408f558f6f148894aa61ba57 and removed in 81daf26878d8a7e14c172fc39fc55c36281b1898. --- .deadcode-out | 3 --- services/pull/commit_status.go | 30 ------------------------------ 2 files changed, 33 deletions(-) diff --git a/.deadcode-out b/.deadcode-out index b420bf15dd..e38f3b634e 100644 --- a/.deadcode-out +++ b/.deadcode-out @@ -218,9 +218,6 @@ code.gitea.io/gitea/routers/web/org code.gitea.io/gitea/services/context GetPrivateContext -code.gitea.io/gitea/services/pull - IsCommitStatusContextSuccess - code.gitea.io/gitea/services/repository IsErrForkAlreadyExist diff --git a/services/pull/commit_status.go b/services/pull/commit_status.go index 0d4763a838..2c77d9cf4e 100644 --- a/services/pull/commit_status.go +++ b/services/pull/commit_status.go @@ -71,36 +71,6 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*git_model.CommitStatus, return returnedStatus } -// IsCommitStatusContextSuccess returns true if all required status check contexts succeed. -func IsCommitStatusContextSuccess(commitStatuses []*git_model.CommitStatus, requiredContexts []string) bool { - // If no specific context is required, require that last commit status is a success - if len(requiredContexts) == 0 { - status := git_model.CalcCommitStatus(commitStatuses) - if status == nil || status.State != structs.CommitStatusSuccess { - return false - } - return true - } - - for _, ctx := range requiredContexts { - var found bool - for _, commitStatus := range commitStatuses { - if commitStatus.Context == ctx { - if commitStatus.State != structs.CommitStatusSuccess { - return false - } - - found = true - break - } - } - if !found { - return false - } - } - return true -} - // IsPullCommitStatusPass returns if all required status checks PASS func IsPullCommitStatusPass(ctx context.Context, pr *issues_model.PullRequest) (bool, error) { pb, err := git_model.GetFirstMatchProtectedBranchRule(ctx, pr.BaseRepoID, pr.BaseBranch)