2022-12-15 15:44:16 -05:00
|
|
|
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
|
|
|
|
package repository
|
|
|
|
|
|
|
|
import (
|
|
|
|
"context"
|
|
|
|
"fmt"
|
|
|
|
"time"
|
|
|
|
|
|
|
|
git_model "code.gitea.io/gitea/models/git"
|
|
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
|
|
"code.gitea.io/gitea/modules/git"
|
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 15:09:51 -05:00
|
|
|
"code.gitea.io/gitea/modules/gitrepo"
|
2022-12-15 15:44:16 -05:00
|
|
|
"code.gitea.io/gitea/modules/lfs"
|
|
|
|
"code.gitea.io/gitea/modules/log"
|
2023-01-16 14:50:53 -05:00
|
|
|
"code.gitea.io/gitea/modules/setting"
|
2023-07-26 02:02:53 -05:00
|
|
|
"code.gitea.io/gitea/modules/timeutil"
|
2022-12-15 15:44:16 -05:00
|
|
|
)
|
|
|
|
|
2023-01-16 14:50:53 -05:00
|
|
|
// GarbageCollectLFSMetaObjectsOptions provides options for GarbageCollectLFSMetaObjects function
|
|
|
|
type GarbageCollectLFSMetaObjectsOptions struct {
|
2024-04-05 04:48:03 -05:00
|
|
|
LogDetail func(format string, v ...any)
|
|
|
|
AutoFix bool
|
|
|
|
OlderThan time.Time
|
|
|
|
UpdatedLessRecentlyThan time.Time
|
2023-01-16 14:50:53 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// GarbageCollectLFSMetaObjects garbage collects LFS objects for all repositories
|
|
|
|
func GarbageCollectLFSMetaObjects(ctx context.Context, opts GarbageCollectLFSMetaObjectsOptions) error {
|
2022-12-15 15:44:16 -05:00
|
|
|
log.Trace("Doing: GarbageCollectLFSMetaObjects")
|
2023-01-16 14:50:53 -05:00
|
|
|
defer log.Trace("Finished: GarbageCollectLFSMetaObjects")
|
2022-12-15 15:44:16 -05:00
|
|
|
|
2023-07-06 11:52:41 -05:00
|
|
|
if opts.LogDetail == nil {
|
|
|
|
opts.LogDetail = log.Debug
|
|
|
|
}
|
|
|
|
|
2023-01-16 14:50:53 -05:00
|
|
|
if !setting.LFS.StartServer {
|
2023-07-06 11:52:41 -05:00
|
|
|
opts.LogDetail("LFS support is disabled")
|
2023-01-16 14:50:53 -05:00
|
|
|
return nil
|
2022-12-15 15:44:16 -05:00
|
|
|
}
|
|
|
|
|
2023-01-16 14:50:53 -05:00
|
|
|
return git_model.IterateRepositoryIDsWithLFSMetaObjects(ctx, func(ctx context.Context, repoID, count int64) error {
|
|
|
|
repo, err := repo_model.GetRepositoryByID(ctx, repoID)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
return GarbageCollectLFSMetaObjectsForRepo(ctx, repo, opts)
|
|
|
|
})
|
2022-12-15 15:44:16 -05:00
|
|
|
}
|
|
|
|
|
2023-01-16 14:50:53 -05:00
|
|
|
// GarbageCollectLFSMetaObjectsForRepo garbage collects LFS objects for a specific repository
|
|
|
|
func GarbageCollectLFSMetaObjectsForRepo(ctx context.Context, repo *repo_model.Repository, opts GarbageCollectLFSMetaObjectsOptions) error {
|
2023-07-06 11:52:41 -05:00
|
|
|
opts.LogDetail("Checking %-v", repo)
|
2023-01-16 14:50:53 -05:00
|
|
|
total, orphaned, collected, deleted := int64(0), 0, 0, 0
|
2023-07-06 11:52:41 -05:00
|
|
|
defer func() {
|
|
|
|
if orphaned == 0 {
|
|
|
|
opts.LogDetail("Found %d total LFSMetaObjects in %-v", total, repo)
|
|
|
|
} else if !opts.AutoFix {
|
|
|
|
opts.LogDetail("Found %d/%d orphaned LFSMetaObjects in %-v", orphaned, total, repo)
|
|
|
|
} else {
|
|
|
|
opts.LogDetail("Collected %d/%d orphaned/%d total LFSMetaObjects in %-v. %d removed from storage.", collected, orphaned, total, repo, deleted)
|
|
|
|
}
|
|
|
|
}()
|
2022-12-15 15:44:16 -05:00
|
|
|
|
Simplify how git repositories are opened (#28937)
## Purpose
This is a refactor toward building an abstraction over managing git
repositories.
Afterwards, it does not matter anymore if they are stored on the local
disk or somewhere remote.
## What this PR changes
We used `git.OpenRepository` everywhere previously.
Now, we should split them into two distinct functions:
Firstly, there are temporary repositories which do not change:
```go
git.OpenRepository(ctx, diskPath)
```
Gitea managed repositories having a record in the database in the
`repository` table are moved into the new package `gitrepo`:
```go
gitrepo.OpenRepository(ctx, repo_model.Repo)
```
Why is `repo_model.Repository` the second parameter instead of file
path?
Because then we can easily adapt our repository storage strategy.
The repositories can be stored locally, however, they could just as well
be stored on a remote server.
## Further changes in other PRs
- A Git Command wrapper on package `gitrepo` could be created. i.e.
`NewCommand(ctx, repo_model.Repository, commands...)`. `git.RunOpts{Dir:
repo.RepoPath()}`, the directory should be empty before invoking this
method and it can be filled in the function only. #28940
- Remove the `RepoPath()`/`WikiPath()` functions to reduce the
possibility of mistakes.
---------
Co-authored-by: delvh <dev.lh@web.de>
2024-01-27 15:09:51 -05:00
|
|
|
gitRepo, err := gitrepo.OpenRepository(ctx, repo)
|
2022-12-15 15:44:16 -05:00
|
|
|
if err != nil {
|
|
|
|
log.Error("Unable to open git repository %-v: %v", repo, err)
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
defer gitRepo.Close()
|
|
|
|
|
|
|
|
store := lfs.NewContentStore()
|
2024-02-24 01:55:19 -05:00
|
|
|
objectFormat := git.ObjectFormatFromName(repo.ObjectFormatName)
|
2022-12-15 15:44:16 -05:00
|
|
|
|
2024-04-05 04:48:03 -05:00
|
|
|
err = git_model.IterateLFSMetaObjectsForRepo(ctx, repo.ID, func(ctx context.Context, metaObject *git_model.LFSMetaObject) error {
|
2022-12-15 15:44:16 -05:00
|
|
|
total++
|
2023-12-13 16:02:00 -05:00
|
|
|
pointerSha := git.ComputeBlobHash(objectFormat, []byte(metaObject.Pointer.StringContent()))
|
2022-12-15 15:44:16 -05:00
|
|
|
|
|
|
|
if gitRepo.IsObjectExist(pointerSha.String()) {
|
2023-01-16 14:50:53 -05:00
|
|
|
return git_model.MarkLFSMetaObject(ctx, metaObject.ID)
|
2022-12-15 15:44:16 -05:00
|
|
|
}
|
|
|
|
orphaned++
|
|
|
|
|
2023-01-16 14:50:53 -05:00
|
|
|
if !opts.AutoFix {
|
2022-12-15 15:44:16 -05:00
|
|
|
return nil
|
|
|
|
}
|
|
|
|
// Non-existent pointer file
|
2023-01-08 22:50:54 -05:00
|
|
|
_, err = git_model.RemoveLFSMetaObjectByOidFn(ctx, repo.ID, metaObject.Oid, func(count int64) error {
|
2022-12-15 15:44:16 -05:00
|
|
|
if count > 0 {
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := store.Delete(metaObject.RelativePath()); err != nil {
|
|
|
|
log.Error("Unable to remove lfs metaobject %s from store: %v", metaObject.Oid, err)
|
|
|
|
}
|
|
|
|
deleted++
|
|
|
|
return nil
|
|
|
|
})
|
|
|
|
if err != nil {
|
|
|
|
return fmt.Errorf("unable to remove meta-object %s in %s: %w", metaObject.Oid, repo.FullName(), err)
|
|
|
|
}
|
|
|
|
collected++
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}, &git_model.IterateLFSMetaObjectsForRepoOptions{
|
|
|
|
// Only attempt to garbage collect lfs meta objects older than a week as the order of git lfs upload
|
|
|
|
// and git object upload is not necessarily guaranteed. It's possible to imagine a situation whereby
|
|
|
|
// an LFS object is uploaded but the git branch is not uploaded immediately, or there are some rapid
|
|
|
|
// changes in new branches that might lead to lfs objects becoming temporarily unassociated with git
|
|
|
|
// objects.
|
|
|
|
//
|
|
|
|
// It is likely that a week is potentially excessive but it should definitely be enough that any
|
|
|
|
// unassociated LFS object is genuinely unassociated.
|
2024-04-05 04:48:03 -05:00
|
|
|
OlderThan: timeutil.TimeStamp(opts.OlderThan.Unix()),
|
|
|
|
UpdatedLessRecentlyThan: timeutil.TimeStamp(opts.UpdatedLessRecentlyThan.Unix()),
|
2022-12-15 15:44:16 -05:00
|
|
|
})
|
2024-04-05 04:48:03 -05:00
|
|
|
if err != nil {
|
2023-01-16 14:50:53 -05:00
|
|
|
return err
|
|
|
|
}
|
|
|
|
return nil
|
2022-12-15 15:44:16 -05:00
|
|
|
}
|