2020-10-12 22:58:34 -05:00
|
|
|
// Copyright 2020 The Gitea Authors. All rights reserved.
|
2022-11-27 13:20:29 -05:00
|
|
|
// SPDX-License-Identifier: MIT
|
2020-10-12 22:58:34 -05:00
|
|
|
|
|
|
|
package storage
|
|
|
|
|
|
|
|
import (
|
2022-11-30 08:39:02 -05:00
|
|
|
"fmt"
|
|
|
|
"io"
|
|
|
|
"net/url"
|
|
|
|
"os"
|
2020-10-12 22:58:34 -05:00
|
|
|
)
|
|
|
|
|
2024-06-05 02:10:42 -05:00
|
|
|
var UninitializedStorage = DiscardStorage("uninitialized storage")
|
2022-11-30 08:39:02 -05:00
|
|
|
|
2024-06-05 02:10:42 -05:00
|
|
|
type DiscardStorage string
|
2022-11-30 08:39:02 -05:00
|
|
|
|
2024-06-05 02:10:42 -05:00
|
|
|
func (s DiscardStorage) Open(_ string) (Object, error) {
|
2022-11-30 08:39:02 -05:00
|
|
|
return nil, fmt.Errorf("%s", s)
|
|
|
|
}
|
|
|
|
|
2024-06-05 02:10:42 -05:00
|
|
|
func (s DiscardStorage) Save(_ string, _ io.Reader, _ int64) (int64, error) {
|
2022-11-30 08:39:02 -05:00
|
|
|
return 0, fmt.Errorf("%s", s)
|
|
|
|
}
|
|
|
|
|
2024-06-05 02:10:42 -05:00
|
|
|
func (s DiscardStorage) Stat(_ string) (os.FileInfo, error) {
|
2022-11-30 08:39:02 -05:00
|
|
|
return nil, fmt.Errorf("%s", s)
|
|
|
|
}
|
|
|
|
|
2024-06-05 02:10:42 -05:00
|
|
|
func (s DiscardStorage) Delete(_ string) error {
|
2022-11-30 08:39:02 -05:00
|
|
|
return fmt.Errorf("%s", s)
|
|
|
|
}
|
|
|
|
|
Fix `missing signature key` error when pulling Docker images with `SERVE_DIRECT` enabled (#32365)
Fix #28121
I did some tests and found that the `missing signature key` error is
caused by an incorrect `Content-Type` header. Gitea correctly sets the
`Content-Type` header when serving files.
https://github.com/go-gitea/gitea/blob/348d1d0f322ca57c459acd902f54821d687ca804/routers/api/packages/container/container.go#L712-L717
However, when `SERVE_DIRECT` is enabled, the `Content-Type` header may
be set to an incorrect value by the storage service. To fix this issue,
we can use query parameters to override response header values.
https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetObject.html
<img width="600px"
src="https://github.com/user-attachments/assets/f2ff90f0-f1df-46f9-9680-b8120222c555"
/>
In this PR, I introduced a new parameter to the `URL` method to support
additional parameters.
```
URL(path, name string, reqParams url.Values) (*url.URL, error)
```
---
Most S3-like services support specifying the content type when storing
objects. However, Gitea always use `application/octet-stream`.
Therefore, I believe we also need to improve the `Save` method to
support storing objects with the correct content type.
https://github.com/go-gitea/gitea/blob/b7fb20e73e63b8edc9b90c52073e248bef428fcc/modules/storage/minio.go#L214-L221
(cherry picked from commit 0690cb076bf63f71988a709f62a9c04660b51a4f)
Conflicts:
- modules/storage/azureblob.go
Dropped the change, as we do not support Azure blob storage.
- modules/storage/helper.go
Resolved by adjusting their `discardStorage` to our
`DiscardStorage`
- routers/api/actions/artifacts.go
routers/api/actions/artifactsv4.go
routers/web/repo/actions/view.go
routers/web/repo/download.go
Resolved the conflicts by manually adding the new `nil`
parameter to the `storage.Attachments.URL()` calls.
Originally conflicted due to differences in the if expression
above these calls.
2024-10-31 10:28:25 -05:00
|
|
|
func (s DiscardStorage) URL(_, _ string, _ url.Values) (*url.URL, error) {
|
2022-11-30 08:39:02 -05:00
|
|
|
return nil, fmt.Errorf("%s", s)
|
|
|
|
}
|
|
|
|
|
2024-06-05 02:10:42 -05:00
|
|
|
func (s DiscardStorage) IterateObjects(_ string, _ func(string, Object) error) error {
|
2022-11-30 08:39:02 -05:00
|
|
|
return fmt.Errorf("%s", s)
|
|
|
|
}
|