2018-12-08 21:19:50 -05:00
|
|
|
// Copyright 2018 The Gitea Authors. All rights reserved.
|
2022-11-27 13:20:29 -05:00
|
|
|
// SPDX-License-Identifier: MIT
|
2018-12-08 21:19:50 -05:00
|
|
|
|
2022-09-02 14:18:23 -05:00
|
|
|
package integration
|
2018-12-08 21:19:50 -05:00
|
|
|
|
|
|
|
|
import (
|
|
|
|
|
"fmt"
|
|
|
|
|
"net/http"
|
|
|
|
|
"testing"
|
|
|
|
|
|
2023-01-17 16:46:03 -05:00
|
|
|
auth_model "code.gitea.io/gitea/models/auth"
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 08:37:34 -05:00
|
|
|
"code.gitea.io/gitea/models/db"
|
2021-11-16 03:53:21 -05:00
|
|
|
"code.gitea.io/gitea/models/unittest"
|
2021-11-24 04:49:20 -05:00
|
|
|
user_model "code.gitea.io/gitea/models/user"
|
2019-05-11 05:21:34 -05:00
|
|
|
api "code.gitea.io/gitea/modules/structs"
|
2022-09-02 14:18:23 -05:00
|
|
|
"code.gitea.io/gitea/tests"
|
2019-01-24 09:12:17 -05:00
|
|
|
|
2018-12-08 21:19:50 -05:00
|
|
|
"github.com/stretchr/testify/assert"
|
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
func TestUserOrgs(t *testing.T) {
|
2022-09-02 14:18:23 -05:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2018-12-08 21:19:50 -05:00
|
|
|
adminUsername := "user1"
|
|
|
|
|
normalUsername := "user2"
|
2021-01-28 16:40:41 -05:00
|
|
|
privateMemberUsername := "user4"
|
|
|
|
|
unrelatedUsername := "user5"
|
2019-01-24 09:12:17 -05:00
|
|
|
|
2021-01-28 16:40:41 -05:00
|
|
|
orgs := getUserOrgs(t, adminUsername, normalUsername)
|
|
|
|
|
|
2022-08-15 21:22:25 -05:00
|
|
|
user3 := unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "user3"})
|
2022-08-21 11:24:05 -05:00
|
|
|
user17 := unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "user17"})
|
2018-12-08 21:19:50 -05:00
|
|
|
|
|
|
|
|
assert.Equal(t, []*api.Organization{
|
2022-08-21 11:24:05 -05:00
|
|
|
{
|
|
|
|
|
ID: 17,
|
2022-09-28 22:27:33 -05:00
|
|
|
Name: user17.Name,
|
2022-08-21 11:24:05 -05:00
|
|
|
UserName: user17.Name,
|
|
|
|
|
FullName: user17.FullName,
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 08:37:34 -05:00
|
|
|
AvatarURL: user17.AvatarLink(db.DefaultContext),
|
2022-08-21 11:24:05 -05:00
|
|
|
Description: "",
|
|
|
|
|
Website: "",
|
|
|
|
|
Location: "",
|
|
|
|
|
Visibility: "public",
|
|
|
|
|
},
|
2018-12-08 21:19:50 -05:00
|
|
|
{
|
|
|
|
|
ID: 3,
|
2022-09-28 22:27:33 -05:00
|
|
|
Name: user3.Name,
|
2019-01-24 09:12:17 -05:00
|
|
|
UserName: user3.Name,
|
|
|
|
|
FullName: user3.FullName,
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 08:37:34 -05:00
|
|
|
AvatarURL: user3.AvatarLink(db.DefaultContext),
|
2018-12-08 21:19:50 -05:00
|
|
|
Description: "",
|
|
|
|
|
Website: "",
|
|
|
|
|
Location: "",
|
2019-05-30 12:57:55 -05:00
|
|
|
Visibility: "public",
|
2018-12-08 21:19:50 -05:00
|
|
|
},
|
|
|
|
|
}, orgs)
|
2021-01-28 16:40:41 -05:00
|
|
|
|
|
|
|
|
// user itself should get it's org's he is a member of
|
|
|
|
|
orgs = getUserOrgs(t, privateMemberUsername, privateMemberUsername)
|
|
|
|
|
assert.Len(t, orgs, 1)
|
|
|
|
|
|
|
|
|
|
// unrelated user should not get private org membership of privateMemberUsername
|
|
|
|
|
orgs = getUserOrgs(t, unrelatedUsername, privateMemberUsername)
|
|
|
|
|
assert.Len(t, orgs, 0)
|
|
|
|
|
|
2023-01-17 16:46:03 -05:00
|
|
|
// not authenticated call should not be allowed
|
|
|
|
|
testUserOrgsUnauthenticated(t, privateMemberUsername)
|
2021-01-28 16:40:41 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
|
|
func getUserOrgs(t *testing.T, userDoer, userCheck string) (orgs []*api.Organization) {
|
2022-01-20 12:46:10 -05:00
|
|
|
token := ""
|
2021-01-28 16:40:41 -05:00
|
|
|
if len(userDoer) != 0 {
|
2023-01-17 16:46:03 -05:00
|
|
|
token = getUserToken(t, userDoer, auth_model.AccessTokenScopeReadOrg)
|
2021-01-28 16:40:41 -05:00
|
|
|
}
|
|
|
|
|
urlStr := fmt.Sprintf("/api/v1/users/%s/orgs?token=%s", userCheck, token)
|
|
|
|
|
req := NewRequest(t, "GET", urlStr)
|
2022-12-01 22:39:42 -05:00
|
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
2021-01-28 16:40:41 -05:00
|
|
|
DecodeJSON(t, resp, &orgs)
|
|
|
|
|
return orgs
|
2018-12-08 21:19:50 -05:00
|
|
|
}
|
|
|
|
|
|
2023-01-17 16:46:03 -05:00
|
|
|
func testUserOrgsUnauthenticated(t *testing.T, userCheck string) {
|
|
|
|
|
session := emptyTestSession(t)
|
|
|
|
|
req := NewRequestf(t, "GET", "/api/v1/users/%s/orgs", userCheck)
|
|
|
|
|
session.MakeRequest(t, req, http.StatusUnauthorized)
|
|
|
|
|
}
|
|
|
|
|
|
2018-12-08 21:19:50 -05:00
|
|
|
func TestMyOrgs(t *testing.T) {
|
2022-09-02 14:18:23 -05:00
|
|
|
defer tests.PrepareTestEnv(t)()
|
2018-12-08 21:19:50 -05:00
|
|
|
|
2021-01-28 16:40:41 -05:00
|
|
|
req := NewRequest(t, "GET", "/api/v1/user/orgs")
|
2022-12-01 22:39:42 -05:00
|
|
|
MakeRequest(t, req, http.StatusUnauthorized)
|
2021-01-28 16:40:41 -05:00
|
|
|
|
2018-12-08 21:19:50 -05:00
|
|
|
normalUsername := "user2"
|
2023-01-17 16:46:03 -05:00
|
|
|
token := getUserToken(t, normalUsername, auth_model.AccessTokenScopeReadOrg)
|
2021-01-28 16:40:41 -05:00
|
|
|
req = NewRequest(t, "GET", "/api/v1/user/orgs?token="+token)
|
2022-12-01 22:39:42 -05:00
|
|
|
resp := MakeRequest(t, req, http.StatusOK)
|
2018-12-08 21:19:50 -05:00
|
|
|
var orgs []*api.Organization
|
|
|
|
|
DecodeJSON(t, resp, &orgs)
|
2022-08-15 21:22:25 -05:00
|
|
|
user3 := unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "user3"})
|
2022-08-21 11:24:05 -05:00
|
|
|
user17 := unittest.AssertExistsAndLoadBean(t, &user_model.User{Name: "user17"})
|
2018-12-08 21:19:50 -05:00
|
|
|
|
|
|
|
|
assert.Equal(t, []*api.Organization{
|
2022-08-21 11:24:05 -05:00
|
|
|
{
|
|
|
|
|
ID: 17,
|
2022-09-28 22:27:33 -05:00
|
|
|
Name: user17.Name,
|
2022-08-21 11:24:05 -05:00
|
|
|
UserName: user17.Name,
|
|
|
|
|
FullName: user17.FullName,
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 08:37:34 -05:00
|
|
|
AvatarURL: user17.AvatarLink(db.DefaultContext),
|
2022-08-21 11:24:05 -05:00
|
|
|
Description: "",
|
|
|
|
|
Website: "",
|
|
|
|
|
Location: "",
|
|
|
|
|
Visibility: "public",
|
|
|
|
|
},
|
2018-12-08 21:19:50 -05:00
|
|
|
{
|
|
|
|
|
ID: 3,
|
2022-09-28 22:27:33 -05:00
|
|
|
Name: user3.Name,
|
2019-01-24 09:12:17 -05:00
|
|
|
UserName: user3.Name,
|
|
|
|
|
FullName: user3.FullName,
|
Add context cache as a request level cache (#22294)
To avoid duplicated load of the same data in an HTTP request, we can set
a context cache to do that. i.e. Some pages may load a user from a
database with the same id in different areas on the same page. But the
code is hidden in two different deep logic. How should we share the
user? As a result of this PR, now if both entry functions accept
`context.Context` as the first parameter and we just need to refactor
`GetUserByID` to reuse the user from the context cache. Then it will not
be loaded twice on an HTTP request.
But of course, sometimes we would like to reload an object from the
database, that's why `RemoveContextData` is also exposed.
The core context cache is here. It defines a new context
```go
type cacheContext struct {
ctx context.Context
data map[any]map[any]any
lock sync.RWMutex
}
var cacheContextKey = struct{}{}
func WithCacheContext(ctx context.Context) context.Context {
return context.WithValue(ctx, cacheContextKey, &cacheContext{
ctx: ctx,
data: make(map[any]map[any]any),
})
}
```
Then you can use the below 4 methods to read/write/del the data within
the same context.
```go
func GetContextData(ctx context.Context, tp, key any) any
func SetContextData(ctx context.Context, tp, key, value any)
func RemoveContextData(ctx context.Context, tp, key any)
func GetWithContextCache[T any](ctx context.Context, cacheGroupKey string, cacheTargetID any, f func() (T, error)) (T, error)
```
Then let's take a look at how `system.GetString` implement it.
```go
func GetSetting(ctx context.Context, key string) (string, error) {
return cache.GetWithContextCache(ctx, contextCacheKey, key, func() (string, error) {
return cache.GetString(genSettingCacheKey(key), func() (string, error) {
res, err := GetSettingNoCache(ctx, key)
if err != nil {
return "", err
}
return res.SettingValue, nil
})
})
}
```
First, it will check if context data include the setting object with the
key. If not, it will query from the global cache which may be memory or
a Redis cache. If not, it will get the object from the database. In the
end, if the object gets from the global cache or database, it will be
set into the context cache.
An object stored in the context cache will only be destroyed after the
context disappeared.
2023-02-15 08:37:34 -05:00
|
|
|
AvatarURL: user3.AvatarLink(db.DefaultContext),
|
2018-12-08 21:19:50 -05:00
|
|
|
Description: "",
|
|
|
|
|
Website: "",
|
|
|
|
|
Location: "",
|
2019-05-30 12:57:55 -05:00
|
|
|
Visibility: "public",
|
2018-12-08 21:19:50 -05:00
|
|
|
},
|
|
|
|
|
}, orgs)
|
|
|
|
|
}
|
