mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-16 21:56:40 -05:00
aad9f90cad
Before, listener ports could be wrong because ParseAddress doesn't know about the user-configured HTTP/HTTPS ports, instead hard-coding port 80 or 443, which could be wrong if the user changed them to something else. Now we defer port and scheme validation/inference to a later part of building the output JSON.
171 lines
5.8 KiB
Go
171 lines
5.8 KiB
Go
package httpcaddyfile
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
func TestParseAddress(t *testing.T) {
|
|
for i, test := range []struct {
|
|
input string
|
|
scheme, host, port, path string
|
|
shouldErr bool
|
|
}{
|
|
{``, "", "", "", "", false},
|
|
{`localhost`, "", "localhost", "", "", false},
|
|
{`localhost:1234`, "", "localhost", "1234", "", false},
|
|
{`localhost:`, "", "localhost", "", "", false},
|
|
{`0.0.0.0`, "", "0.0.0.0", "", "", false},
|
|
{`127.0.0.1:1234`, "", "127.0.0.1", "1234", "", false},
|
|
{`:1234`, "", "", "1234", "", false},
|
|
{`[::1]`, "", "::1", "", "", false},
|
|
{`[::1]:1234`, "", "::1", "1234", "", false},
|
|
{`:`, "", "", "", "", false},
|
|
{`:http`, "", "", "", "", true},
|
|
{`:https`, "", "", "", "", true},
|
|
{`localhost:http`, "", "", "", "", true}, // using service name in port is verboten, as of Go 1.12.8
|
|
{`localhost:https`, "", "", "", "", true},
|
|
{`http://localhost:https`, "", "", "", "", true}, // conflict
|
|
{`http://localhost:http`, "", "", "", "", true}, // repeated scheme
|
|
{`host:https/path`, "", "", "", "", true},
|
|
{`http://localhost:443`, "http", "localhost", "443", "", false}, // NOTE: not conventional
|
|
{`https://localhost:80`, "https", "localhost", "80", "", false}, // NOTE: not conventional
|
|
{`http://localhost`, "http", "localhost", "", "", false},
|
|
{`https://localhost`, "https", "localhost", "", "", false},
|
|
{`http://{env.APP_DOMAIN}`, "http", "{env.APP_DOMAIN}", "", "", false},
|
|
{`{env.APP_DOMAIN}:80`, "", "{env.APP_DOMAIN}", "80", "", false},
|
|
{`{env.APP_DOMAIN}/path`, "", "{env.APP_DOMAIN}", "", "/path", false},
|
|
{`example.com/{env.APP_PATH}`, "", "example.com", "", "/{env.APP_PATH}", false},
|
|
{`http://127.0.0.1`, "http", "127.0.0.1", "", "", false},
|
|
{`https://127.0.0.1`, "https", "127.0.0.1", "", "", false},
|
|
{`http://[::1]`, "http", "::1", "", "", false},
|
|
{`http://localhost:1234`, "http", "localhost", "1234", "", false},
|
|
{`https://127.0.0.1:1234`, "https", "127.0.0.1", "1234", "", false},
|
|
{`http://[::1]:1234`, "http", "::1", "1234", "", false},
|
|
{``, "", "", "", "", false},
|
|
{`::1`, "", "::1", "", "", false},
|
|
{`localhost::`, "", "localhost::", "", "", false},
|
|
{`#$%@`, "", "#$%@", "", "", false}, // don't want to presume what the hostname could be
|
|
{`host/path`, "", "host", "", "/path", false},
|
|
{`http://host/`, "http", "host", "", "/", false},
|
|
{`//asdf`, "", "", "", "//asdf", false},
|
|
{`:1234/asdf`, "", "", "1234", "/asdf", false},
|
|
{`http://host/path`, "http", "host", "", "/path", false},
|
|
{`https://host:443/path/foo`, "https", "host", "443", "/path/foo", false},
|
|
{`host:80/path`, "", "host", "80", "/path", false},
|
|
{`/path`, "", "", "", "/path", false},
|
|
} {
|
|
actual, err := ParseAddress(test.input)
|
|
|
|
if err != nil && !test.shouldErr {
|
|
t.Errorf("Test %d (%s): Expected no error, but had error: %v", i, test.input, err)
|
|
}
|
|
if err == nil && test.shouldErr {
|
|
t.Errorf("Test %d (%s): Expected error, but had none (%#v)", i, test.input, actual)
|
|
}
|
|
|
|
if !test.shouldErr && actual.Original != test.input {
|
|
t.Errorf("Test %d (%s): Expected original '%s', got '%s'", i, test.input, test.input, actual.Original)
|
|
}
|
|
if actual.Scheme != test.scheme {
|
|
t.Errorf("Test %d (%s): Expected scheme '%s', got '%s'", i, test.input, test.scheme, actual.Scheme)
|
|
}
|
|
if actual.Host != test.host {
|
|
t.Errorf("Test %d (%s): Expected host '%s', got '%s'", i, test.input, test.host, actual.Host)
|
|
}
|
|
if actual.Port != test.port {
|
|
t.Errorf("Test %d (%s): Expected port '%s', got '%s'", i, test.input, test.port, actual.Port)
|
|
}
|
|
if actual.Path != test.path {
|
|
t.Errorf("Test %d (%s): Expected path '%s', got '%s'", i, test.input, test.path, actual.Path)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestAddressString(t *testing.T) {
|
|
for i, test := range []struct {
|
|
addr Address
|
|
expected string
|
|
}{
|
|
{Address{Scheme: "http", Host: "host", Port: "1234", Path: "/path"}, "http://host:1234/path"},
|
|
{Address{Scheme: "", Host: "host", Port: "", Path: ""}, "http://host"},
|
|
{Address{Scheme: "", Host: "host", Port: "80", Path: ""}, "http://host"},
|
|
{Address{Scheme: "", Host: "host", Port: "443", Path: ""}, "https://host"},
|
|
{Address{Scheme: "https", Host: "host", Port: "443", Path: ""}, "https://host"},
|
|
{Address{Scheme: "https", Host: "host", Port: "", Path: ""}, "https://host"},
|
|
{Address{Scheme: "", Host: "host", Port: "80", Path: "/path"}, "http://host/path"},
|
|
{Address{Scheme: "http", Host: "", Port: "1234", Path: ""}, "http://:1234"},
|
|
{Address{Scheme: "", Host: "", Port: "", Path: ""}, ""},
|
|
} {
|
|
actual := test.addr.String()
|
|
if actual != test.expected {
|
|
t.Errorf("Test %d: expected '%s' but got '%s'", i, test.expected, actual)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestKeyNormalization(t *testing.T) {
|
|
testCases := []struct {
|
|
input string
|
|
expect string
|
|
}{
|
|
{
|
|
input: "http://host:1234/path",
|
|
expect: "http://host:1234/path",
|
|
},
|
|
{
|
|
input: "HTTP://A/ABCDEF",
|
|
expect: "http://a/ABCDEF",
|
|
},
|
|
{
|
|
input: "A/ABCDEF",
|
|
expect: "a/ABCDEF",
|
|
},
|
|
{
|
|
input: "A:2015/Path",
|
|
expect: "a:2015/Path",
|
|
},
|
|
{
|
|
input: ":80",
|
|
expect: ":80",
|
|
},
|
|
{
|
|
input: ":443",
|
|
expect: ":443",
|
|
},
|
|
{
|
|
input: ":1234",
|
|
expect: ":1234",
|
|
},
|
|
{
|
|
input: "",
|
|
expect: "",
|
|
},
|
|
{
|
|
input: ":",
|
|
expect: "",
|
|
},
|
|
{
|
|
input: "[::]",
|
|
expect: "::",
|
|
},
|
|
}
|
|
for i, tc := range testCases {
|
|
addr, err := ParseAddress(tc.input)
|
|
if err != nil {
|
|
t.Errorf("Test %d: Parsing address '%s': %v", i, tc.input, err)
|
|
continue
|
|
}
|
|
expect := tc.expect
|
|
if !caseSensitivePath {
|
|
// every other part of the address should be lowercased when normalized,
|
|
// so simply lower-case the whole thing to do case-insensitive comparison
|
|
// of the path as well
|
|
expect = strings.ToLower(expect)
|
|
}
|
|
if actual := addr.Normalize().Key(); actual != expect {
|
|
t.Errorf("Test %d: Normalized key for address '%s' was '%s' but expected '%s'", i, tc.input, actual, expect)
|
|
}
|
|
|
|
}
|
|
}
|