mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-23 22:27:38 -05:00
9fe2ef417c
* Regexp support for simple rewrite rule * Add negate option for simplicity * ascertain explicit regexp char
225 lines
5.9 KiB
Go
225 lines
5.9 KiB
Go
// Copyright 2015 Light Code Labs, LLC
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
package rewrite
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mholt/caddy"
|
|
"github.com/mholt/caddy/caddyhttp/httpserver"
|
|
)
|
|
|
|
func TestSetup(t *testing.T) {
|
|
c := caddy.NewTestController("http", `rewrite /from /to`)
|
|
err := setup(c)
|
|
if err != nil {
|
|
t.Errorf("Expected no errors, but got: %v", err)
|
|
}
|
|
mids := httpserver.GetConfig(c).Middleware()
|
|
if len(mids) == 0 {
|
|
t.Fatal("Expected middleware, had 0 instead")
|
|
}
|
|
|
|
handler := mids[0](httpserver.EmptyNext)
|
|
myHandler, ok := handler.(Rewrite)
|
|
if !ok {
|
|
t.Fatalf("Expected handler to be type Rewrite, got: %#v", handler)
|
|
}
|
|
|
|
if !httpserver.SameNext(myHandler.Next, httpserver.EmptyNext) {
|
|
t.Error("'Next' field of handler was not set properly")
|
|
}
|
|
|
|
if len(myHandler.Rules) != 1 {
|
|
t.Errorf("Expected handler to have %d rule, has %d instead", 1, len(myHandler.Rules))
|
|
}
|
|
}
|
|
|
|
// newSimpleRule is convenience test function for SimpleRule.
|
|
func newSimpleRule(t *testing.T, from, to string, negate ...bool) Rule {
|
|
var n bool
|
|
if len(negate) > 0 {
|
|
n = negate[0]
|
|
}
|
|
rule, err := NewSimpleRule(from, to, n)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
return rule
|
|
}
|
|
|
|
func TestRewriteParse(t *testing.T) {
|
|
simpleTests := []struct {
|
|
input string
|
|
shouldErr bool
|
|
expected []Rule
|
|
}{
|
|
{`rewrite /from /to`, false, []Rule{
|
|
newSimpleRule(t, "/from", "/to"),
|
|
}},
|
|
{`rewrite /from /to
|
|
rewrite a b`, false, []Rule{
|
|
newSimpleRule(t, "/from", "/to"),
|
|
newSimpleRule(t, "a", "b"),
|
|
}},
|
|
{`rewrite a`, true, []Rule{}},
|
|
{`rewrite`, true, []Rule{}},
|
|
{`rewrite a b c`, false, []Rule{
|
|
newSimpleRule(t, "a", "b c"),
|
|
}},
|
|
{`rewrite not a b c`, false, []Rule{
|
|
newSimpleRule(t, "a", "b c", true),
|
|
}},
|
|
}
|
|
|
|
for i, test := range simpleTests {
|
|
actual, err := rewriteParse(caddy.NewTestController("http", test.input))
|
|
|
|
if err == nil && test.shouldErr {
|
|
t.Errorf("Test %d didn't error, but it should have", i)
|
|
} else if err != nil && !test.shouldErr {
|
|
t.Errorf("Test %d errored, but it shouldn't have; got '%v'", i, err)
|
|
} else if err != nil && test.shouldErr {
|
|
continue
|
|
}
|
|
|
|
if len(actual) != len(test.expected) {
|
|
t.Fatalf("Test %d expected %d rules, but got %d",
|
|
i, len(test.expected), len(actual))
|
|
}
|
|
|
|
for j, e := range test.expected {
|
|
actualRule := actual[j].(*SimpleRule)
|
|
expectedRule := e.(*SimpleRule)
|
|
|
|
if actualRule.Regexp.String() != expectedRule.Regexp.String() {
|
|
t.Errorf("Test %d, rule %d: Expected From=%s, got %s",
|
|
i, j, expectedRule.Regexp.String(), actualRule.Regexp.String())
|
|
}
|
|
|
|
if actualRule.To != expectedRule.To {
|
|
t.Errorf("Test %d, rule %d: Expected To=%s, got %s",
|
|
i, j, expectedRule.Regexp.String(), actualRule.Regexp.String())
|
|
}
|
|
|
|
if actualRule.Negate != expectedRule.Negate {
|
|
t.Errorf("Test %d, rule %d: Expected Negate=%v, got %v",
|
|
i, j, expectedRule.Negate, actualRule.Negate)
|
|
}
|
|
}
|
|
}
|
|
|
|
regexpTests := []struct {
|
|
input string
|
|
shouldErr bool
|
|
expected []Rule
|
|
}{
|
|
{`rewrite {
|
|
r .*
|
|
to /to /index.php?
|
|
}`, false, []Rule{
|
|
ComplexRule{Base: "/", To: "/to /index.php?", Regexp: regexp.MustCompile(".*")},
|
|
}},
|
|
{`rewrite {
|
|
regexp .*
|
|
to /to
|
|
ext / html txt
|
|
}`, false, []Rule{
|
|
ComplexRule{Base: "/", To: "/to", Exts: []string{"/", "html", "txt"}, Regexp: regexp.MustCompile(".*")},
|
|
}},
|
|
{`rewrite /path {
|
|
r rr
|
|
to /dest
|
|
}
|
|
rewrite / {
|
|
regexp [a-z]+
|
|
to /to /to2
|
|
}
|
|
`, false, []Rule{
|
|
ComplexRule{Base: "/path", To: "/dest", Regexp: regexp.MustCompile("rr")},
|
|
ComplexRule{Base: "/", To: "/to /to2", Regexp: regexp.MustCompile("[a-z]+")},
|
|
}},
|
|
{`rewrite {
|
|
r .*
|
|
}`, true, []Rule{
|
|
ComplexRule{},
|
|
}},
|
|
{`rewrite {
|
|
|
|
}`, true, []Rule{
|
|
ComplexRule{},
|
|
}},
|
|
{`rewrite /`, true, []Rule{
|
|
ComplexRule{},
|
|
}},
|
|
{`rewrite {
|
|
if {path} match /
|
|
to /to
|
|
}`, false, []Rule{
|
|
ComplexRule{Base: "/", To: "/to"},
|
|
}},
|
|
}
|
|
|
|
for i, test := range regexpTests {
|
|
actual, err := rewriteParse(caddy.NewTestController("http", test.input))
|
|
|
|
if err == nil && test.shouldErr {
|
|
t.Errorf("Test %d didn't error, but it should have", i)
|
|
} else if err != nil && !test.shouldErr {
|
|
t.Errorf("Test %d errored, but it shouldn't have; got '%v'", i, err)
|
|
} else if err != nil && test.shouldErr {
|
|
continue
|
|
}
|
|
|
|
if len(actual) != len(test.expected) {
|
|
t.Fatalf("Test %d expected %d rules, but got %d",
|
|
i, len(test.expected), len(actual))
|
|
}
|
|
|
|
for j, e := range test.expected {
|
|
actualRule := actual[j].(ComplexRule)
|
|
expectedRule := e.(ComplexRule)
|
|
|
|
if actualRule.Base != expectedRule.Base {
|
|
t.Errorf("Test %d, rule %d: Expected Base=%s, got %s",
|
|
i, j, expectedRule.Base, actualRule.Base)
|
|
}
|
|
|
|
if actualRule.To != expectedRule.To {
|
|
t.Errorf("Test %d, rule %d: Expected To=%s, got %s",
|
|
i, j, expectedRule.To, actualRule.To)
|
|
}
|
|
|
|
if fmt.Sprint(actualRule.Exts) != fmt.Sprint(expectedRule.Exts) {
|
|
t.Errorf("Test %d, rule %d: Expected Ext=%v, got %v",
|
|
i, j, expectedRule.To, actualRule.To)
|
|
}
|
|
|
|
if actualRule.Regexp != nil {
|
|
if actualRule.Regexp.String() != expectedRule.Regexp.String() {
|
|
t.Errorf("Test %d, rule %d: Expected Pattern=%s, got %s",
|
|
i, j, actualRule.Regexp.String(), expectedRule.Regexp.String())
|
|
}
|
|
}
|
|
}
|
|
|
|
if rules_fmt := fmt.Sprintf("%v", actual); strings.HasPrefix(rules_fmt, "%!") {
|
|
t.Errorf("Test %d: Failed to string encode: %#v", i, rules_fmt)
|
|
}
|
|
}
|
|
}
|