mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-23 22:27:38 -05:00
e2544597a1
According to https://tools.ietf.org/html/rfc7232#section-2.1 > Likewise, a validator is weak if it is shared by two or more representations of a given resource at the same time, unless those representations have identical representation data. For example, if the origin server sends the same validator for a representation with a gzip content coding applied as it does for a representation with no content coding, then that validator is weak. Therefore, after gzip, we should change the original etag to weak etag.
182 lines
4.3 KiB
Go
182 lines
4.3 KiB
Go
package gzip
|
|
|
|
import (
|
|
"compress/gzip"
|
|
"fmt"
|
|
"io/ioutil"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mholt/caddy/caddyhttp/httpserver"
|
|
)
|
|
|
|
func TestGzipHandler(t *testing.T) {
|
|
pathFilter := PathFilter{make(Set)}
|
|
badPaths := []string{"/bad", "/nogzip", "/nongzip"}
|
|
for _, p := range badPaths {
|
|
pathFilter.IgnoredPaths.Add(p)
|
|
}
|
|
extFilter := ExtFilter{make(Set)}
|
|
for _, e := range []string{".txt", ".html", ".css", ".md"} {
|
|
extFilter.Exts.Add(e)
|
|
}
|
|
gz := Gzip{Configs: []Config{
|
|
{RequestFilters: []RequestFilter{pathFilter, extFilter}},
|
|
}}
|
|
|
|
w := httptest.NewRecorder()
|
|
gz.Next = nextFunc(true)
|
|
var exts = []string{
|
|
".html", ".css", ".md",
|
|
}
|
|
for _, e := range exts {
|
|
url := "/file" + e
|
|
r, err := http.NewRequest("GET", url, nil)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
r.Header.Set("Accept-Encoding", "gzip")
|
|
w.Header().Set("ETag", `"2n9cd"`)
|
|
_, err = gz.ServeHTTP(w, r)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
|
|
// The second pass, test if the ETag is already weak
|
|
w.Header().Set("ETag", `W/"2n9cd"`)
|
|
_, err = gz.ServeHTTP(w, r)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
}
|
|
|
|
w = httptest.NewRecorder()
|
|
gz.Next = nextFunc(false)
|
|
for _, p := range badPaths {
|
|
for _, e := range exts {
|
|
url := p + "/file" + e
|
|
r, err := http.NewRequest("GET", url, nil)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
r.Header.Set("Accept-Encoding", "gzip")
|
|
_, err = gz.ServeHTTP(w, r)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
w = httptest.NewRecorder()
|
|
gz.Next = nextFunc(false)
|
|
exts = []string{
|
|
".htm1", ".abc", ".mdx",
|
|
}
|
|
for _, e := range exts {
|
|
url := "/file" + e
|
|
r, err := http.NewRequest("GET", url, nil)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
r.Header.Set("Accept-Encoding", "gzip")
|
|
_, err = gz.ServeHTTP(w, r)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
}
|
|
|
|
// test all levels
|
|
w = httptest.NewRecorder()
|
|
gz.Next = nextFunc(true)
|
|
for i := 0; i <= gzip.BestCompression; i++ {
|
|
gz.Configs[0].Level = i
|
|
r, err := http.NewRequest("GET", "/file.txt", nil)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
r.Header.Set("Accept-Encoding", "gzip")
|
|
_, err = gz.ServeHTTP(w, r)
|
|
if err != nil {
|
|
t.Error(err)
|
|
}
|
|
}
|
|
}
|
|
|
|
func nextFunc(shouldGzip bool) httpserver.Handler {
|
|
return httpserver.HandlerFunc(func(w http.ResponseWriter, r *http.Request) (int, error) {
|
|
// write a relatively large text file
|
|
b, err := ioutil.ReadFile("testdata/test.txt")
|
|
if err != nil {
|
|
return 500, err
|
|
}
|
|
if _, err := w.Write(b); err != nil {
|
|
return 500, err
|
|
}
|
|
|
|
if shouldGzip {
|
|
if w.Header().Get("Content-Encoding") != "gzip" {
|
|
return 0, fmt.Errorf("Content-Encoding must be gzip, found %v", w.Header().Get("Content-Encoding"))
|
|
}
|
|
if w.Header().Get("Vary") != "Accept-Encoding" {
|
|
return 0, fmt.Errorf("Vary must be Accept-Encoding, found %v", w.Header().Get("Vary"))
|
|
}
|
|
etag := w.Header().Get("ETag")
|
|
if etag != "" && etag != `W/"2n9cd"` {
|
|
return 0, fmt.Errorf("ETag must be converted to weak Etag, found %v", w.Header().Get("ETag"))
|
|
}
|
|
if _, ok := w.(*gzipResponseWriter); !ok {
|
|
return 0, fmt.Errorf("ResponseWriter should be gzipResponseWriter, found %T", w)
|
|
}
|
|
if strings.Contains(w.Header().Get("Content-Type"), "application/x-gzip") {
|
|
return 0, fmt.Errorf("Content-Type should not be gzip")
|
|
}
|
|
return 0, nil
|
|
}
|
|
if r.Header.Get("Accept-Encoding") == "" {
|
|
return 0, fmt.Errorf("Accept-Encoding header expected")
|
|
}
|
|
if w.Header().Get("Content-Encoding") == "gzip" {
|
|
return 0, fmt.Errorf("Content-Encoding must not be gzip, found gzip")
|
|
}
|
|
if _, ok := w.(*gzipResponseWriter); ok {
|
|
return 0, fmt.Errorf("ResponseWriter should not be gzipResponseWriter")
|
|
}
|
|
return 0, nil
|
|
})
|
|
}
|
|
|
|
func BenchmarkGzip(b *testing.B) {
|
|
pathFilter := PathFilter{make(Set)}
|
|
badPaths := []string{"/bad", "/nogzip", "/nongzip"}
|
|
for _, p := range badPaths {
|
|
pathFilter.IgnoredPaths.Add(p)
|
|
}
|
|
extFilter := ExtFilter{make(Set)}
|
|
for _, e := range []string{".txt", ".html", ".css", ".md"} {
|
|
extFilter.Exts.Add(e)
|
|
}
|
|
gz := Gzip{Configs: []Config{
|
|
{
|
|
RequestFilters: []RequestFilter{pathFilter, extFilter},
|
|
},
|
|
}}
|
|
|
|
w := httptest.NewRecorder()
|
|
gz.Next = nextFunc(true)
|
|
url := "/file.txt"
|
|
r, err := http.NewRequest("GET", url, nil)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
r.Header.Set("Accept-Encoding", "gzip")
|
|
|
|
b.ResetTimer()
|
|
for i := 0; i < b.N; i++ {
|
|
_, err = gz.ServeHTTP(w, r)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
}
|