1
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-12-16 21:56:40 -05:00
caddy/caddyconfig/httpcaddyfile
Matthew Holt b3d35a4995
httpcaddyfile: Don't put localhost in public APs (fix #4220)
If an email is specified in global options, a site called 'localhost' shouldn't be bunched together with public DNS names in the automation policies, which get the default, public-CA issuers. Fix old test that did this.

I also noticed that these two:

    localhost {
    }
    example.com {
    }

and

    localhost, example.com {
    }

produce slightly different TLS automation policies. The former is what the new test case covers, and we have logic that removes the empty automation policy for localhost so that auto-HTTPS can implicitly create one. (We prefer that whenever possible.) But the latter case produces two automation policies, with the second one being for localhost, with an explicit internal issuer. It's not wrong, just more explicit than it needs to be.

I'd really like to completely rewrite the code from scratch that generates automation policies, hopefully there is a simpler, more correct algorithm.
2021-06-25 11:28:32 -06:00
..
addresses.go httpcaddyfile: Configure servers via global options (#3836) 2020-11-23 12:46:50 -07:00
addresses_fuzz.go ci: fuzz: switch engine from libfuzzer to native go-fuzz (#3194) 2020-03-26 18:20:34 -06:00
addresses_test.go httpcaddyfile: Don't lowercase placeholder contents (fixes #3264) 2020-04-14 16:11:46 -06:00
builtins.go httpcaddyfile: Add auto_https ignore_loaded_certs (#4077) 2021-05-02 12:11:27 -06:00
builtins_test.go caddyconfig: add global option for configuring loggers (#4028) 2021-03-12 13:00:02 -07:00
directives.go httpcaddyfile: Don't add HTTP hosts to TLS APs (fix #4176 and fix #4198) 2021-06-09 14:35:09 -06:00
directives_test.go tests: Clean up redundant type declarations 2020-04-10 08:48:21 -06:00
httptype.go httpcaddyfile: Add grace_period global option (#4152) 2021-05-07 16:18:17 -06:00
httptype_test.go caddyfile: Introduce basic linting and fmt check (#3923) 2021-01-04 11:11:36 -07:00
options.go httpcaddyfile: Add preferred_chains global option and issuer subdirective (#4192) 2021-06-08 14:10:37 -06:00
options_test.go caddyconfig: add global option for configuring loggers (#4028) 2021-03-12 13:00:02 -07:00
pkiapp.go httpcaddyfile: Add skip_install_trust global option (#4153) 2021-06-07 12:18:49 -06:00
serveroptions.go caddyfile: Refactor unmarshaling of module tokens 2021-01-05 14:39:30 -07:00
tlsapp.go httpcaddyfile: Don't put localhost in public APs (fix #4220) 2021-06-25 11:28:32 -06:00
tlsapp_test.go httpcaddyfile: Revise automation policy generation (#3824) 2020-10-28 20:36:00 -06:00