mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-23 22:27:38 -05:00
a798e0c951
- Server types no longer need to store their own contexts; they are stored on the caddy.Instance, which means each context will be properly GC'ed when the instance is stopped. Server types should use type assertions to convert from caddy.Context to their concrete context type when they need to use it. - Pass the entire context into httpserver.GetConfig instead of only the Key field. - caddy.NewTestController now requires a server type string so it can create a controller with the proper concrete context associated with that server type. Tests still need more attention so that we can test the proper creation of startup functions, etc.
240 lines
5.6 KiB
Go
240 lines
5.6 KiB
Go
package rewrite
|
|
|
|
import (
|
|
"fmt"
|
|
"regexp"
|
|
"testing"
|
|
|
|
"github.com/mholt/caddy"
|
|
"github.com/mholt/caddy/caddyhttp/httpserver"
|
|
)
|
|
|
|
func TestSetup(t *testing.T) {
|
|
c := caddy.NewTestController("http", `rewrite /from /to`)
|
|
err := setup(c)
|
|
if err != nil {
|
|
t.Errorf("Expected no errors, but got: %v", err)
|
|
}
|
|
mids := httpserver.GetConfig(c).Middleware()
|
|
if len(mids) == 0 {
|
|
t.Fatal("Expected middleware, had 0 instead")
|
|
}
|
|
|
|
handler := mids[0](httpserver.EmptyNext)
|
|
myHandler, ok := handler.(Rewrite)
|
|
if !ok {
|
|
t.Fatalf("Expected handler to be type Rewrite, got: %#v", handler)
|
|
}
|
|
|
|
if !httpserver.SameNext(myHandler.Next, httpserver.EmptyNext) {
|
|
t.Error("'Next' field of handler was not set properly")
|
|
}
|
|
|
|
if len(myHandler.Rules) != 1 {
|
|
t.Errorf("Expected handler to have %d rule, has %d instead", 1, len(myHandler.Rules))
|
|
}
|
|
}
|
|
|
|
func TestRewriteParse(t *testing.T) {
|
|
simpleTests := []struct {
|
|
input string
|
|
shouldErr bool
|
|
expected []Rule
|
|
}{
|
|
{`rewrite /from /to`, false, []Rule{
|
|
SimpleRule{From: "/from", To: "/to"},
|
|
}},
|
|
{`rewrite /from /to
|
|
rewrite a b`, false, []Rule{
|
|
SimpleRule{From: "/from", To: "/to"},
|
|
SimpleRule{From: "a", To: "b"},
|
|
}},
|
|
{`rewrite a`, true, []Rule{}},
|
|
{`rewrite`, true, []Rule{}},
|
|
{`rewrite a b c`, false, []Rule{
|
|
SimpleRule{From: "a", To: "b c"},
|
|
}},
|
|
}
|
|
|
|
for i, test := range simpleTests {
|
|
actual, err := rewriteParse(caddy.NewTestController("http", test.input))
|
|
|
|
if err == nil && test.shouldErr {
|
|
t.Errorf("Test %d didn't error, but it should have", i)
|
|
} else if err != nil && !test.shouldErr {
|
|
t.Errorf("Test %d errored, but it shouldn't have; got '%v'", i, err)
|
|
} else if err != nil && test.shouldErr {
|
|
continue
|
|
}
|
|
|
|
if len(actual) != len(test.expected) {
|
|
t.Fatalf("Test %d expected %d rules, but got %d",
|
|
i, len(test.expected), len(actual))
|
|
}
|
|
|
|
for j, e := range test.expected {
|
|
actualRule := actual[j].(SimpleRule)
|
|
expectedRule := e.(SimpleRule)
|
|
|
|
if actualRule.From != expectedRule.From {
|
|
t.Errorf("Test %d, rule %d: Expected From=%s, got %s",
|
|
i, j, expectedRule.From, actualRule.From)
|
|
}
|
|
|
|
if actualRule.To != expectedRule.To {
|
|
t.Errorf("Test %d, rule %d: Expected To=%s, got %s",
|
|
i, j, expectedRule.To, actualRule.To)
|
|
}
|
|
}
|
|
}
|
|
|
|
regexpTests := []struct {
|
|
input string
|
|
shouldErr bool
|
|
expected []Rule
|
|
}{
|
|
{`rewrite {
|
|
r .*
|
|
to /to /index.php?
|
|
}`, false, []Rule{
|
|
&ComplexRule{Base: "/", To: "/to /index.php?", Regexp: regexp.MustCompile(".*")},
|
|
}},
|
|
{`rewrite {
|
|
regexp .*
|
|
to /to
|
|
ext / html txt
|
|
}`, false, []Rule{
|
|
&ComplexRule{Base: "/", To: "/to", Exts: []string{"/", "html", "txt"}, Regexp: regexp.MustCompile(".*")},
|
|
}},
|
|
{`rewrite /path {
|
|
r rr
|
|
to /dest
|
|
}
|
|
rewrite / {
|
|
regexp [a-z]+
|
|
to /to /to2
|
|
}
|
|
`, false, []Rule{
|
|
&ComplexRule{Base: "/path", To: "/dest", Regexp: regexp.MustCompile("rr")},
|
|
&ComplexRule{Base: "/", To: "/to /to2", Regexp: regexp.MustCompile("[a-z]+")},
|
|
}},
|
|
{`rewrite {
|
|
r .*
|
|
}`, true, []Rule{
|
|
&ComplexRule{},
|
|
}},
|
|
{`rewrite {
|
|
|
|
}`, true, []Rule{
|
|
&ComplexRule{},
|
|
}},
|
|
{`rewrite /`, true, []Rule{
|
|
&ComplexRule{},
|
|
}},
|
|
{`rewrite {
|
|
to /to
|
|
if {path} is a
|
|
}`, false, []Rule{
|
|
&ComplexRule{Base: "/", To: "/to", Ifs: []If{{A: "{path}", Operator: "is", B: "a"}}},
|
|
}},
|
|
{`rewrite {
|
|
status 500
|
|
}`, true, []Rule{
|
|
&ComplexRule{},
|
|
}},
|
|
{`rewrite {
|
|
status 400
|
|
}`, false, []Rule{
|
|
&ComplexRule{Base: "/", Status: 400},
|
|
}},
|
|
{`rewrite {
|
|
to /to
|
|
status 400
|
|
}`, false, []Rule{
|
|
&ComplexRule{Base: "/", To: "/to", Status: 400},
|
|
}},
|
|
{`rewrite {
|
|
status 399
|
|
}`, true, []Rule{
|
|
&ComplexRule{},
|
|
}},
|
|
{`rewrite {
|
|
status 200
|
|
}`, false, []Rule{
|
|
&ComplexRule{Base: "/", Status: 200},
|
|
}},
|
|
{`rewrite {
|
|
to /to
|
|
status 200
|
|
}`, false, []Rule{
|
|
&ComplexRule{Base: "/", To: "/to", Status: 200},
|
|
}},
|
|
{`rewrite {
|
|
status 199
|
|
}`, true, []Rule{
|
|
&ComplexRule{},
|
|
}},
|
|
{`rewrite {
|
|
status 0
|
|
}`, true, []Rule{
|
|
&ComplexRule{},
|
|
}},
|
|
{`rewrite {
|
|
to /to
|
|
status 0
|
|
}`, true, []Rule{
|
|
&ComplexRule{},
|
|
}},
|
|
}
|
|
|
|
for i, test := range regexpTests {
|
|
actual, err := rewriteParse(caddy.NewTestController("http", test.input))
|
|
|
|
if err == nil && test.shouldErr {
|
|
t.Errorf("Test %d didn't error, but it should have", i)
|
|
} else if err != nil && !test.shouldErr {
|
|
t.Errorf("Test %d errored, but it shouldn't have; got '%v'", i, err)
|
|
} else if err != nil && test.shouldErr {
|
|
continue
|
|
}
|
|
|
|
if len(actual) != len(test.expected) {
|
|
t.Fatalf("Test %d expected %d rules, but got %d",
|
|
i, len(test.expected), len(actual))
|
|
}
|
|
|
|
for j, e := range test.expected {
|
|
actualRule := actual[j].(*ComplexRule)
|
|
expectedRule := e.(*ComplexRule)
|
|
|
|
if actualRule.Base != expectedRule.Base {
|
|
t.Errorf("Test %d, rule %d: Expected Base=%s, got %s",
|
|
i, j, expectedRule.Base, actualRule.Base)
|
|
}
|
|
|
|
if actualRule.To != expectedRule.To {
|
|
t.Errorf("Test %d, rule %d: Expected To=%s, got %s",
|
|
i, j, expectedRule.To, actualRule.To)
|
|
}
|
|
|
|
if fmt.Sprint(actualRule.Exts) != fmt.Sprint(expectedRule.Exts) {
|
|
t.Errorf("Test %d, rule %d: Expected Ext=%v, got %v",
|
|
i, j, expectedRule.To, actualRule.To)
|
|
}
|
|
|
|
if actualRule.Regexp != nil {
|
|
if actualRule.String() != expectedRule.String() {
|
|
t.Errorf("Test %d, rule %d: Expected Pattern=%s, got %s",
|
|
i, j, expectedRule.String(), actualRule.String())
|
|
}
|
|
}
|
|
|
|
if fmt.Sprint(actualRule.Ifs) != fmt.Sprint(expectedRule.Ifs) {
|
|
t.Errorf("Test %d, rule %d: Expected Pattern=%s, got %s",
|
|
i, j, fmt.Sprint(expectedRule.Ifs), fmt.Sprint(actualRule.Ifs))
|
|
}
|
|
|
|
}
|
|
}
|
|
|
|
}
|