mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-23 22:27:38 -05:00
8e75ae2495
If another ACME client is trying to solve a challenge for a name not being served by Caddy on the same machine where Caddy is running, the HTTP challenge will be consumed by Caddy rather than allowing the owner to use the Caddyfile to proxy the challenge. With this change, we only consume requests for HTTP challenges for hostnames that we recognize. Before doing the challenge, we add the name to a set, and when seeing if we should proxy the challenge, we first check the path of course to see if it is an HTTP challenge; if it is, we then check that set to see if the hostname is in the set. Only if it is, do we consume it. Otherwise, the request is treated like any other, allowing the owner to configure a proxy for such requests to another ACME client.
70 lines
1.9 KiB
Go
70 lines
1.9 KiB
Go
package caddytls
|
|
|
|
import (
|
|
"net"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"testing"
|
|
)
|
|
|
|
func TestHTTPChallengeHandlerNoOp(t *testing.T) {
|
|
namesObtaining.Add([]string{"localhost"})
|
|
|
|
// try base paths and host names that aren't
|
|
// handled by this handler
|
|
for _, url := range []string{
|
|
"http://localhost/",
|
|
"http://localhost/foo.html",
|
|
"http://localhost/.git",
|
|
"http://localhost/.well-known/",
|
|
"http://localhost/.well-known/acme-challenging",
|
|
"http://other/.well-known/acme-challenge/foo",
|
|
} {
|
|
req, err := http.NewRequest("GET", url, nil)
|
|
if err != nil {
|
|
t.Fatalf("Could not craft request, got error: %v", err)
|
|
}
|
|
rw := httptest.NewRecorder()
|
|
if HTTPChallengeHandler(rw, req, DefaultHTTPAlternatePort) {
|
|
t.Errorf("Got true with this URL, but shouldn't have: %s", url)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestHTTPChallengeHandlerSuccess(t *testing.T) {
|
|
expectedPath := challengeBasePath + "/asdf"
|
|
|
|
// Set up fake acme handler backend to make sure proxying succeeds
|
|
var proxySuccess bool
|
|
ts := httptest.NewUnstartedServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
|
|
proxySuccess = true
|
|
if r.URL.Path != expectedPath {
|
|
t.Errorf("Expected path '%s' but got '%s' instead", expectedPath, r.URL.Path)
|
|
}
|
|
}))
|
|
|
|
// Custom listener that uses the port we expect
|
|
ln, err := net.Listen("tcp", "127.0.0.1:"+DefaultHTTPAlternatePort)
|
|
if err != nil {
|
|
t.Fatalf("Unable to start test server listener: %v", err)
|
|
}
|
|
ts.Listener = ln
|
|
|
|
// Tell this package that we are handling a challenge for 127.0.0.1
|
|
namesObtaining.Add([]string{"127.0.0.1"})
|
|
|
|
// Start our engines and run the test
|
|
ts.Start()
|
|
defer ts.Close()
|
|
req, err := http.NewRequest("GET", "http://127.0.0.1:"+DefaultHTTPAlternatePort+expectedPath, nil)
|
|
if err != nil {
|
|
t.Fatalf("Could not craft request, got error: %v", err)
|
|
}
|
|
rw := httptest.NewRecorder()
|
|
|
|
HTTPChallengeHandler(rw, req, DefaultHTTPAlternatePort)
|
|
|
|
if !proxySuccess {
|
|
t.Fatal("Expected request to be proxied, but it wasn't")
|
|
}
|
|
}
|