mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-23 22:27:38 -05:00
55bded68c2
* fixing panic when root is symlink checking root path is a symlink before os.Stat which panics * fixing formatting * adding test to verify symlink root path check * fixing typo
52 lines
1.2 KiB
Go
52 lines
1.2 KiB
Go
package root
|
|
|
|
import (
|
|
"log"
|
|
"os"
|
|
|
|
"github.com/mholt/caddy"
|
|
"github.com/mholt/caddy/caddyhttp/httpserver"
|
|
)
|
|
|
|
func init() {
|
|
caddy.RegisterPlugin("root", caddy.Plugin{
|
|
ServerType: "http",
|
|
Action: setupRoot,
|
|
})
|
|
}
|
|
|
|
func setupRoot(c *caddy.Controller) error {
|
|
config := httpserver.GetConfig(c)
|
|
|
|
for c.Next() {
|
|
if !c.NextArg() {
|
|
return c.ArgErr()
|
|
}
|
|
config.Root = c.Val()
|
|
if c.NextArg() {
|
|
// only one argument allowed
|
|
return c.ArgErr()
|
|
}
|
|
}
|
|
//first check that the path is not a symlink, os.Stat panics when this is true
|
|
info, _ := os.Lstat(config.Root)
|
|
if info != nil && info.Mode()&os.ModeSymlink == os.ModeSymlink {
|
|
//just print out info, delegate responsibility for symlink validity to
|
|
//underlying Go framework, no need to test / verify twice
|
|
log.Printf("[INFO] Root path is symlink: %s", config.Root)
|
|
} else {
|
|
// Check if root path exists
|
|
_, err := os.Stat(config.Root)
|
|
if err != nil {
|
|
if os.IsNotExist(err) {
|
|
// Allow this, because the folder might appear later.
|
|
// But make sure the user knows!
|
|
log.Printf("[WARNING] Root path does not exist: %s", config.Root)
|
|
} else {
|
|
return c.Errf("Unable to access root path '%s': %v", config.Root, err)
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|