mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-23 22:27:38 -05:00
5e0f4083c4
fix issue #1044 Signed-off-by: Tw <tw19881113@gmail.com>
123 lines
2.7 KiB
Go
123 lines
2.7 KiB
Go
package log
|
|
|
|
import (
|
|
"bytes"
|
|
"io/ioutil"
|
|
"log"
|
|
"net/http"
|
|
"net/http/httptest"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mholt/caddy/caddyhttp/httpserver"
|
|
)
|
|
|
|
type erroringMiddleware struct{}
|
|
|
|
func (erroringMiddleware) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) {
|
|
if rr, ok := w.(*httpserver.ResponseRecorder); ok {
|
|
rr.Replacer.Set("testval", "foobar")
|
|
}
|
|
return http.StatusNotFound, nil
|
|
}
|
|
|
|
func TestLoggedStatus(t *testing.T) {
|
|
var f bytes.Buffer
|
|
var next erroringMiddleware
|
|
rule := Rule{
|
|
PathScope: "/",
|
|
Entries: []*Entry{{
|
|
Format: DefaultLogFormat + " {testval}",
|
|
Log: log.New(&f, "", 0),
|
|
}},
|
|
}
|
|
|
|
logger := Logger{
|
|
Rules: []*Rule{&rule},
|
|
Next: next,
|
|
}
|
|
|
|
r, err := http.NewRequest("GET", "/", nil)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
rec := httptest.NewRecorder()
|
|
|
|
status, err := logger.ServeHTTP(rec, r)
|
|
if status != 0 {
|
|
t.Errorf("Expected status to be 0, but was %d", status)
|
|
}
|
|
|
|
if err != nil {
|
|
t.Errorf("Expected error to be nil, instead got: %v", err)
|
|
}
|
|
|
|
logged := f.String()
|
|
if !strings.Contains(logged, "404 13") {
|
|
t.Errorf("Expected log entry to contain '404 13', but it didn't: %s", logged)
|
|
}
|
|
|
|
// check custom placeholder
|
|
if !strings.Contains(logged, "foobar") {
|
|
t.Errorf("Expected the log entry to contain 'foobar' (custom placeholder), but it didn't: %s", logged)
|
|
}
|
|
}
|
|
|
|
func TestLogRequestBody(t *testing.T) {
|
|
var got bytes.Buffer
|
|
logger := Logger{
|
|
Rules: []*Rule{{
|
|
PathScope: "/",
|
|
Entries: []*Entry{{
|
|
Format: "{request_body}",
|
|
Log: log.New(&got, "", 0),
|
|
}},
|
|
}},
|
|
Next: httpserver.HandlerFunc(func(w http.ResponseWriter, r *http.Request) (int, error) {
|
|
// drain up body
|
|
ioutil.ReadAll(r.Body)
|
|
return 0, nil
|
|
}),
|
|
}
|
|
|
|
for i, c := range []struct {
|
|
body string
|
|
expect string
|
|
}{
|
|
{"", "\n"},
|
|
{"{hello} world!", "{hello} world!\n"},
|
|
{func() string {
|
|
length := httpserver.MaxLogBodySize + 100
|
|
b := make([]byte, length)
|
|
for i := 0; i < length; i++ {
|
|
b[i] = 0xab
|
|
}
|
|
return string(b)
|
|
}(), func() string {
|
|
b := make([]byte, httpserver.MaxLogBodySize)
|
|
for i := 0; i < httpserver.MaxLogBodySize; i++ {
|
|
b[i] = 0xab
|
|
}
|
|
return string(b) + "\n"
|
|
}(),
|
|
},
|
|
} {
|
|
got.Reset()
|
|
r, err := http.NewRequest("POST", "/", bytes.NewBufferString(c.body))
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
r.Header.Set("Content-Type", "application/json")
|
|
status, err := logger.ServeHTTP(httptest.NewRecorder(), r)
|
|
if status != 0 {
|
|
t.Errorf("case %d: Expected status to be 0, but was %d", i, status)
|
|
}
|
|
if err != nil {
|
|
t.Errorf("case %d: Expected error to be nil, instead got: %v", i, err)
|
|
}
|
|
if got.String() != c.expect {
|
|
t.Errorf("case %d: Expected body %q, but got %q", i, c.expect, got.String())
|
|
}
|
|
}
|
|
}
|