Infrastructure/caddy
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-12-23 22:27:38 -05:00
Code Issues Activity

Set Go 1.8's ReadHeaderTimeout and IdleTimeout

Browse source
This commit is contained in:
Matthew Holt 2017-01-24 20:09:03 -07:00
parent 139a3cfb13
commit d264a2cf0a
No known key found for this signature in database
GPG key ID: 2A349DD577D586A5
2 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
caddyhttp/httpserver/server.go
View file

@ -394,11 +394,10 @@ func makeHTTPServer(addr string, group []*SiteConfig) *http.Server {
} }
// set the final values on the server // set the final values on the server
// TODO: ReadHeaderTimeout and IdleTimeout require Go 1.8
s.ReadTimeout = min.ReadTimeout s.ReadTimeout = min.ReadTimeout
// s.ReadHeaderTimeout = min.ReadHeaderTimeout s.ReadHeaderTimeout = min.ReadHeaderTimeout
s.WriteTimeout = min.WriteTimeout s.WriteTimeout = min.WriteTimeout
// s.IdleTimeout = min.IdleTimeout s.IdleTimeout = min.IdleTimeout
return s return s
} }

13
caddyhttp/httpserver/server_test.go
View file

@ -100,15 +100,14 @@ func TestMakeHTTPServer(t *testing.T) {
if got, want := actual.ReadTimeout, tc.expected.ReadTimeout; got != want { if got, want := actual.ReadTimeout, tc.expected.ReadTimeout; got != want {
t.Errorf("Test %d: Expected ReadTimeout=%v, but was %v", i, want, got) t.Errorf("Test %d: Expected ReadTimeout=%v, but was %v", i, want, got)
} }
// TODO: ReadHeaderTimeout and IdleTimeout require Go 1.8 if got, want := actual.ReadHeaderTimeout, tc.expected.ReadHeaderTimeout; got != want {
// if got, want := actual.ReadHeaderTimeout, tc.expected.ReadHeaderTimeout; got != want { t.Errorf("Test %d: Expected ReadHeaderTimeout=%v, but was %v", i, want, got)
// t.Errorf("Test %d: Expected ReadHeaderTimeout=%v, but was %v", i, want, got) }
// }
if got, want := actual.WriteTimeout, tc.expected.WriteTimeout; got != want { if got, want := actual.WriteTimeout, tc.expected.WriteTimeout; got != want {
t.Errorf("Test %d: Expected WriteTimeout=%v, but was %v", i, want, got) t.Errorf("Test %d: Expected WriteTimeout=%v, but was %v", i, want, got)
} }
// if got, want := actual.IdleTimeout, tc.expected.IdleTimeout; got != want { if got, want := actual.IdleTimeout, tc.expected.IdleTimeout; got != want {
// t.Errorf("Test %d: Expected IdleTimeout=%v, but was %v", i, want, got) t.Errorf("Test %d: Expected IdleTimeout=%v, but was %v", i, want, got)
// } }
} }
} }