Infrastructure/caddy
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-12-30 22:34:15 -05:00
Code Issues Activity

caddyconfig: Fix httploader leak from unused responses (#5159)

Browse source 
fixes #5158

Signed-off-by: Chris Lahaye <mail@chrislahaye.com>

Signed-off-by: Chris Lahaye <mail@chrislahaye.com>
This commit is contained in:
Chris Lahaye 2022-10-24 19:58:30 +02:00 committed by GitHub
parent ed503118dd
commit bbe3663167
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
caddyconfig/httploader.go
View file

@ -134,16 +134,16 @@ func doHttpCallWithRetries(ctx caddy.Context, client *http.Client, request *http
var err error var err error
const maxAttempts = 10 const maxAttempts = 10
// attempt up to 10 times
for i := 0; i < maxAttempts; i++ { for i := 0; i < maxAttempts; i++ {
resp, err = attemptHttpCall(client, request) resp, err = attemptHttpCall(client, request)
if err != nil && i < maxAttempts-1 { if err != nil && i < maxAttempts-1 {
// wait 500ms before reattempting, or until context is done
select { select {
case <-time.After(time.Millisecond * 500): case <-time.After(time.Millisecond * 500):
case <-ctx.Done(): case <-ctx.Done():
return resp, ctx.Err() return resp, ctx.Err()
} }
} else {
break
} }
} }