mirror of
https://github.com/caddyserver/caddy.git
synced 2024-12-16 21:56:40 -05:00
caddyfile: Fix import
replacing unrelated placeholders (#4129)
* caddyfile: Fix `import` replacing unrelated placeholders See https://caddy.community/t/snippet-issue-works-outside-snippet/12231 So it turns out that `NewReplacer()` gives a replacer with some global defaults (like `{env.*}` and some system and time placeholders), which is not ideal when running `import` because we just want to replace `{args.*}` only, and nothing else. * caddyfile: Add test
This commit is contained in:
parent
1e218e1d2e
commit
a8d45277ca
3 changed files with 44 additions and 1 deletions
|
@ -321,7 +321,7 @@ func (p *parser) doImport() error {
|
|||
args := p.RemainingArgs()
|
||||
|
||||
// add args to the replacer
|
||||
repl := caddy.NewReplacer()
|
||||
repl := caddy.NewEmptyReplacer()
|
||||
for index, arg := range args {
|
||||
repl.Set("args."+strconv.Itoa(index), arg)
|
||||
}
|
||||
|
|
|
@ -0,0 +1,31 @@
|
|||
(foo) {
|
||||
respond {env.FOO}
|
||||
}
|
||||
|
||||
:80 {
|
||||
import foo
|
||||
}
|
||||
----------
|
||||
{
|
||||
"apps": {
|
||||
"http": {
|
||||
"servers": {
|
||||
"srv0": {
|
||||
"listen": [
|
||||
":80"
|
||||
],
|
||||
"routes": [
|
||||
{
|
||||
"handle": [
|
||||
{
|
||||
"body": "{env.FOO}",
|
||||
"handler": "static_response"
|
||||
}
|
||||
]
|
||||
}
|
||||
]
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
12
replacer.go
12
replacer.go
|
@ -36,6 +36,18 @@ func NewReplacer() *Replacer {
|
|||
return rep
|
||||
}
|
||||
|
||||
// NewEmptyReplacer returns a new Replacer,
|
||||
// without the global default replacements.
|
||||
func NewEmptyReplacer() *Replacer {
|
||||
rep := &Replacer{
|
||||
static: make(map[string]interface{}),
|
||||
}
|
||||
rep.providers = []ReplacerFunc{
|
||||
rep.fromStatic,
|
||||
}
|
||||
return rep
|
||||
}
|
||||
|
||||
// Replacer can replace values in strings.
|
||||
// A default/empty Replacer is not valid;
|
||||
// use NewReplacer to make one.
|
||||
|
|
Loading…
Reference in a new issue