From 878ae7ea89acca742b68b9c1220cc1c757d0f201 Mon Sep 17 00:00:00 2001 From: Matthew Holt Date: Sat, 28 Mar 2015 16:49:18 -0600 Subject: [PATCH] Refactored rewrite middleware to return errors --- middleware/rewrite/rewrite.go | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/middleware/rewrite/rewrite.go b/middleware/rewrite/rewrite.go index 31e9395eb..f894ce141 100644 --- a/middleware/rewrite/rewrite.go +++ b/middleware/rewrite/rewrite.go @@ -28,15 +28,16 @@ func New(c middleware.Controller) (middleware.Middleware, error) { rewrites = append(rewrites, rule) } - return func(next http.HandlerFunc) http.HandlerFunc { - return func(w http.ResponseWriter, r *http.Request) { + // TODO: Why can't we just return an http.Handler here instead? + return func(next middleware.HandlerFunc) middleware.HandlerFunc { + return func(w http.ResponseWriter, r *http.Request) (int, error) { for _, rule := range rewrites { if r.URL.Path == rule.From { r.URL.Path = rule.To break } } - next(w, r) + return next(w, r) } }, nil }