diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 94250f88..22e13973 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -49,7 +49,7 @@ jobs: - name: golangci-lint uses: golangci/golangci-lint-action@v6 with: - version: v1.60 + version: latest # Windows times out frequently after about 5m50s if we don't set a longer timeout. args: --timeout 10m diff --git a/.golangci.yml b/.golangci.yml index 74e3503c..e8b2a55d 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -35,7 +35,6 @@ linters: - errcheck - errname - exhaustive - - exportloopref - gci - gofmt - goimports @@ -145,6 +144,9 @@ output: issues: exclude-rules: + - text: 'G115' # TODO: Either we should fix the issues or nuke the linter if it's bad + linters: + - gosec # we aren't calling unknown URL - text: 'G107' # G107: Url provided to HTTP request as taint input linters: diff --git a/modules/caddyhttp/server.go b/modules/caddyhttp/server.go index 9dfa1bb6..e301bdc6 100644 --- a/modules/caddyhttp/server.go +++ b/modules/caddyhttp/server.go @@ -817,7 +817,6 @@ func (s *Server) logRequest( } if fields == nil { - userID, _ := repl.GetString("http.auth.user.id") reqBodyLength := 0