Infrastructure/caddy
0
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-12-23 22:27:38 -05:00
Code Issues Activity

letsencrypt: Don't assume default port of 443

Browse source
This commit is contained in:
Matthew Holt 2015-11-17 16:17:43 -07:00
parent b9244cdf2e
commit 659df6967e
1 changed files with 5 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
caddy/letsencrypt/letsencrypt.go
View file

@ -218,7 +218,7 @@ func existingCertAndKey(host string) bool {
// disk (if already exists) or created new and registered via ACME // disk (if already exists) or created new and registered via ACME
// and saved to the file system for next time. // and saved to the file system for next time.
func newClient(leEmail string) (*acme.Client, error) { func newClient(leEmail string) (*acme.Client, error) {
return newClientPort(leEmail, exposePort) return newClientPort(leEmail, "")
} }
// newClientPort does the same thing as newClient, except it creates a // newClientPort does the same thing as newClient, except it creates a
@ -469,14 +469,10 @@ var (
// Some essential values related to the Let's Encrypt process // Some essential values related to the Let's Encrypt process
const ( const (
// The port to expose to the CA server for Simple HTTP Challenge. // alternatePort is the port on which the acme client will open a
// NOTE: Let's Encrypt requires port 443. If exposePort is not 443, // listener and solve the CA's challenges. If this alternate port
// then port 443 must be forwarded to exposePort. // is used instead of the default port (80 or 443), then the
exposePort = "443" // default port for the challenge must be forwarded to this one.
// If port 443 is in use by a Caddy server instance, then this is
// port on which the acme client will solve challenges. (Whatever is
// listening on port 443 must proxy ACME requests to this port.)
alternatePort = "5033" alternatePort = "5033"
// How often to check certificates for renewal. // How often to check certificates for renewal.