Infrastructure/caddy
1
Fork 0
mirror of https://github.com/caddyserver/caddy.git synced 2024-12-16 21:56:40 -05:00
Code Issues Activity

reverseproxy: Change errors writing the response to warning. (#6532)

Browse source 
Most of the errors that can be seen here are write errors due to clients
aborting the request from their side. Often seen ones include:

	* writing: ... write: broken pipe
	* writing: ... connection timed out
	* writing: http2: stream closed
	* writing: timeout...
	* writing: h3 error...

Most of these errors are beyond of the control of caddy on the client side,
probably nothing can be done on the server side. It still warrants
researching when these errors occur very often, so a change in level from
error to warn is better here to not polute the logs with errors in the
normal case.
This commit is contained in:
Jens-Uwe Mager 2024-08-21 19:39:20 +02:00 committed by GitHub
parent 54a0c8f948
commit 2bb2ecc549
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
modules/caddyhttp/reverseproxy/reverseproxy.go
View file

@ -979,7 +979,7 @@ func (h *Handler) finalizeResponse(
// we'll just log the error and abort the stream here and panic just as // we'll just log the error and abort the stream here and panic just as
// the standard lib's proxy to propagate the stream error. // the standard lib's proxy to propagate the stream error.
// see issue https://github.com/caddyserver/caddy/issues/5951 // see issue https://github.com/caddyserver/caddy/issues/5951
logger.Error("aborting with incomplete response", zap.Error(err)) logger.Warn("aborting with incomplete response", zap.Error(err))
// no extra logging from stdlib // no extra logging from stdlib
panic(http.ErrAbortHandler) panic(http.ErrAbortHandler)
} }