From 1fc151faec8421bf77c6db8b21880e7bec0d2b02 Mon Sep 17 00:00:00 2001 From: Will Norris Date: Sat, 18 May 2024 19:47:46 -0700 Subject: [PATCH] caddytls: remove ClientHelloSNICtxKey (#6326) --- modules/caddytls/certmanagers.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/modules/caddytls/certmanagers.go b/modules/caddytls/certmanagers.go index b383a03f..f65a78b0 100644 --- a/modules/caddytls/certmanagers.go +++ b/modules/caddytls/certmanagers.go @@ -22,9 +22,6 @@ func init() { caddy.RegisterModule(HTTPCertGetter{}) } -// For referencing the requested SNI server name. -const ClientHelloSNICtxKey caddy.CtxKey = "client_hello_sni" - // Tailscale is a module that can get certificates from the local Tailscale process. type Tailscale struct { logger *zap.Logger @@ -44,7 +41,6 @@ func (ts *Tailscale) Provision(ctx caddy.Context) error { } func (ts Tailscale) GetCertificate(ctx context.Context, hello *tls.ClientHelloInfo) (*tls.Certificate, error) { - ctx = context.WithValue(ctx, ClientHelloSNICtxKey, hello.ServerName) canGetCert, err := ts.canHazCertificate(ctx, hello) if err == nil && !canGetCert { return nil, nil // pass-thru: Tailscale can't offer a cert for this name