2017-09-23 00:56:58 -05:00
|
|
|
// Copyright 2015 Light Code Labs, LLC
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
|
|
// you may not use this file except in compliance with the License.
|
|
|
|
// You may obtain a copy of the License at
|
|
|
|
//
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
//
|
|
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
|
|
// See the License for the specific language governing permissions and
|
|
|
|
// limitations under the License.
|
|
|
|
|
2016-06-05 23:39:23 -05:00
|
|
|
// Package fastcgi has middleware that acts as a FastCGI client. Requests
|
|
|
|
// that get forwarded to FastCGI stop the middleware execution chain.
|
|
|
|
// The most common use for this package is to serve PHP websites via php-fpm.
|
|
|
|
package fastcgi
|
|
|
|
|
|
|
|
import (
|
2017-07-18 13:52:53 -05:00
|
|
|
"context"
|
2016-06-05 23:39:23 -05:00
|
|
|
"errors"
|
2017-10-03 08:17:54 -05:00
|
|
|
"fmt"
|
2016-06-05 23:39:23 -05:00
|
|
|
"io"
|
2016-11-29 21:26:51 -05:00
|
|
|
"net"
|
2016-06-05 23:39:23 -05:00
|
|
|
"net/http"
|
httpserver/all: Clean up and standardize request URL handling (#1633)
* httpserver/all: Clean up and standardize request URL handling
The HTTP server now always creates a context value on the request which
is a copy of the request's URL struct. It should not be modified by
middlewares, but it is safe to get the value out of the request and make
changes to it locally-scoped. Thus, the value in the context always
stores the original request URL information as it was received. Any
rewrites that happen will be to the request's URL field directly.
The HTTP server no longer cleans /sanitizes the request URL. It made too
many strong assumptions and ended up making a lot of middleware more
complicated, including upstream proxying (and fastcgi). To alleviate
this complexity, we no longer change the request URL. Middlewares are
responsible to access the disk safely by using http.Dir or, if not
actually opening files, they can use httpserver.SafePath().
I'm hoping this will address issues with #1624, #1584, #1582, and others.
* staticfiles: Fix test on Windows
@abiosoft: I still can't figure out exactly what this is for. 😅
* Use (potentially) changed URL for browse redirects, as before
* Use filepath.ToSlash, clean up a couple proxy test cases
* Oops, fix variable name
2017-05-02 00:11:10 -05:00
|
|
|
"net/url"
|
2016-06-05 23:39:23 -05:00
|
|
|
"os"
|
|
|
|
"path"
|
|
|
|
"path/filepath"
|
|
|
|
"strconv"
|
|
|
|
"strings"
|
2017-07-18 13:52:53 -05:00
|
|
|
"sync/atomic"
|
2016-11-19 11:05:29 -05:00
|
|
|
"time"
|
2016-06-05 23:39:23 -05:00
|
|
|
|
2017-09-01 23:15:53 -05:00
|
|
|
"github.com/mholt/caddy"
|
2016-06-05 23:39:23 -05:00
|
|
|
"github.com/mholt/caddy/caddyhttp/httpserver"
|
|
|
|
)
|
|
|
|
|
|
|
|
// Handler is a middleware type that can handle requests as a FastCGI client.
|
|
|
|
type Handler struct {
|
|
|
|
Next httpserver.Handler
|
|
|
|
Rules []Rule
|
|
|
|
Root string
|
|
|
|
FileSys http.FileSystem
|
|
|
|
|
|
|
|
// These are sent to CGI scripts in env variables
|
|
|
|
SoftwareName string
|
|
|
|
SoftwareVersion string
|
|
|
|
ServerName string
|
|
|
|
ServerPort string
|
|
|
|
}
|
|
|
|
|
|
|
|
// ServeHTTP satisfies the httpserver.Handler interface.
|
|
|
|
func (h Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) {
|
|
|
|
for _, rule := range h.Rules {
|
2017-05-02 12:20:50 -05:00
|
|
|
// First requirement: Base path must match request path. If it doesn't,
|
|
|
|
// we check to make sure the leading slash is not missing, and if so,
|
|
|
|
// we check again with it prepended. This is in case people forget
|
|
|
|
// a leading slash when performing rewrites, and we don't want to expose
|
|
|
|
// the contents of the (likely PHP) script. See issue #1645.
|
|
|
|
hpath := httpserver.Path(r.URL.Path)
|
|
|
|
if !hpath.Matches(rule.Path) {
|
|
|
|
if strings.HasPrefix(string(hpath), "/") {
|
|
|
|
// this is a normal-looking path, and it doesn't match; try next rule
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
hpath = httpserver.Path("/" + string(hpath)) // prepend leading slash
|
|
|
|
if !hpath.Matches(rule.Path) {
|
|
|
|
// even after fixing the request path, it still doesn't match; try next rule
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
}
|
|
|
|
// The path must also be allowed (not ignored).
|
|
|
|
if !rule.AllowedPath(r.URL.Path) {
|
2016-06-05 23:39:23 -05:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// In addition to matching the path, a request must meet some
|
|
|
|
// other criteria before being proxied as FastCGI. For example,
|
|
|
|
// we probably want to exclude static assets (CSS, JS, images...)
|
|
|
|
// but we also want to be flexible for the script we proxy to.
|
|
|
|
|
|
|
|
fpath := r.URL.Path
|
|
|
|
|
|
|
|
if idx, ok := httpserver.IndexFile(h.FileSys, fpath, rule.IndexFiles); ok {
|
|
|
|
fpath = idx
|
|
|
|
// Index file present.
|
|
|
|
// If request path cannot be split, return error.
|
|
|
|
if !rule.canSplit(fpath) {
|
|
|
|
return http.StatusInternalServerError, ErrIndexMissingSplit
|
|
|
|
}
|
|
|
|
} else {
|
|
|
|
// No index file present.
|
|
|
|
// If request path cannot be split, ignore request.
|
|
|
|
if !rule.canSplit(fpath) {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// These criteria work well in this order for PHP sites
|
|
|
|
if !h.exists(fpath) || fpath[len(fpath)-1] == '/' || strings.HasSuffix(fpath, rule.Ext) {
|
|
|
|
|
|
|
|
// Create environment for CGI script
|
|
|
|
env, err := h.buildEnv(r, rule, fpath)
|
|
|
|
if err != nil {
|
|
|
|
return http.StatusInternalServerError, err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Connect to FastCGI gateway
|
2017-10-03 08:17:54 -05:00
|
|
|
address, err := rule.Address()
|
|
|
|
if err != nil {
|
|
|
|
return http.StatusBadGateway, err
|
|
|
|
}
|
|
|
|
network, address := parseAddress(address)
|
2017-07-18 13:52:53 -05:00
|
|
|
|
|
|
|
ctx := context.Background()
|
|
|
|
if rule.ConnectTimeout > 0 {
|
|
|
|
var cancel context.CancelFunc
|
|
|
|
ctx, cancel = context.WithTimeout(ctx, rule.ConnectTimeout)
|
|
|
|
defer cancel()
|
|
|
|
}
|
|
|
|
|
|
|
|
fcgiBackend, err := DialContext(ctx, network, address)
|
2016-09-24 00:29:23 -05:00
|
|
|
if err != nil {
|
|
|
|
return http.StatusBadGateway, err
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
2016-11-29 21:26:51 -05:00
|
|
|
defer fcgiBackend.Close()
|
2017-07-18 13:52:53 -05:00
|
|
|
|
|
|
|
// read/write timeouts
|
|
|
|
if err := fcgiBackend.SetReadTimeout(rule.ReadTimeout); err != nil {
|
|
|
|
return http.StatusInternalServerError, err
|
|
|
|
}
|
|
|
|
if err := fcgiBackend.SetSendTimeout(rule.SendTimeout); err != nil {
|
|
|
|
return http.StatusInternalServerError, err
|
|
|
|
}
|
2016-06-05 23:39:23 -05:00
|
|
|
|
|
|
|
var resp *http.Response
|
2017-03-09 21:36:04 -05:00
|
|
|
|
|
|
|
var contentLength int64
|
|
|
|
// if ContentLength is already set
|
|
|
|
if r.ContentLength > 0 {
|
|
|
|
contentLength = r.ContentLength
|
|
|
|
} else {
|
|
|
|
contentLength, _ = strconv.ParseInt(r.Header.Get("Content-Length"), 10, 64)
|
|
|
|
}
|
2016-06-05 23:39:23 -05:00
|
|
|
switch r.Method {
|
|
|
|
case "HEAD":
|
|
|
|
resp, err = fcgiBackend.Head(env)
|
|
|
|
case "GET":
|
|
|
|
resp, err = fcgiBackend.Get(env)
|
|
|
|
case "OPTIONS":
|
|
|
|
resp, err = fcgiBackend.Options(env)
|
|
|
|
default:
|
|
|
|
resp, err = fcgiBackend.Post(env, r.Method, r.Header.Get("Content-Type"), r.Body, contentLength)
|
|
|
|
}
|
|
|
|
|
2017-07-18 13:52:53 -05:00
|
|
|
if resp != nil && resp.Body != nil {
|
|
|
|
defer resp.Body.Close()
|
|
|
|
}
|
|
|
|
|
2016-11-29 21:26:51 -05:00
|
|
|
if err != nil {
|
|
|
|
if err, ok := err.(net.Error); ok && err.Timeout() {
|
|
|
|
return http.StatusGatewayTimeout, err
|
|
|
|
} else if err != io.EOF {
|
|
|
|
return http.StatusBadGateway, err
|
|
|
|
}
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// Write response header
|
|
|
|
writeHeader(w, resp)
|
|
|
|
|
|
|
|
// Write the response body
|
|
|
|
_, err = io.Copy(w, resp.Body)
|
|
|
|
if err != nil {
|
|
|
|
return http.StatusBadGateway, err
|
|
|
|
}
|
|
|
|
|
|
|
|
// Log any stderr output from upstream
|
2017-07-18 13:52:53 -05:00
|
|
|
if fcgiBackend.stderr.Len() != 0 {
|
2016-06-05 23:39:23 -05:00
|
|
|
// Remove trailing newline, error logger already does this.
|
2017-07-18 13:52:53 -05:00
|
|
|
err = LogError(strings.TrimSuffix(fcgiBackend.stderr.String(), "\n"))
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// Normally we would return the status code if it is an error status (>= 400),
|
|
|
|
// however, upstream FastCGI apps don't know about our contract and have
|
|
|
|
// probably already written an error page. So we just return 0, indicating
|
|
|
|
// that the response body is already written. However, we do return any
|
|
|
|
// error value so it can be logged.
|
|
|
|
// Note that the proxy middleware works the same way, returning status=0.
|
|
|
|
return 0, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
return h.Next.ServeHTTP(w, r)
|
|
|
|
}
|
|
|
|
|
2016-09-24 00:29:23 -05:00
|
|
|
// parseAddress returns the network and address of fcgiAddress.
|
2016-06-05 23:39:23 -05:00
|
|
|
// The first string is the network, "tcp" or "unix", implied from the scheme and address.
|
2016-09-24 00:29:23 -05:00
|
|
|
// The second string is fcgiAddress, with scheme prefixes removed.
|
2016-06-05 23:39:23 -05:00
|
|
|
// The two returned strings can be used as parameters to the Dial() function.
|
2016-09-24 00:29:23 -05:00
|
|
|
func parseAddress(fcgiAddress string) (string, string) {
|
2016-06-05 23:39:23 -05:00
|
|
|
// check if address has tcp scheme explicitly set
|
2016-09-24 00:29:23 -05:00
|
|
|
if strings.HasPrefix(fcgiAddress, "tcp://") {
|
|
|
|
return "tcp", fcgiAddress[len("tcp://"):]
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
// check if address has fastcgi scheme explicitly set
|
2016-09-24 00:29:23 -05:00
|
|
|
if strings.HasPrefix(fcgiAddress, "fastcgi://") {
|
|
|
|
return "tcp", fcgiAddress[len("fastcgi://"):]
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
// check if unix socket
|
2016-09-24 00:29:23 -05:00
|
|
|
if trim := strings.HasPrefix(fcgiAddress, "unix"); strings.HasPrefix(fcgiAddress, "/") || trim {
|
2016-06-05 23:39:23 -05:00
|
|
|
if trim {
|
2016-09-24 00:29:23 -05:00
|
|
|
return "unix", fcgiAddress[len("unix:"):]
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
2016-09-24 00:29:23 -05:00
|
|
|
return "unix", fcgiAddress
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
// default case, a plain tcp address with no scheme
|
2016-09-24 00:29:23 -05:00
|
|
|
return "tcp", fcgiAddress
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
func writeHeader(w http.ResponseWriter, r *http.Response) {
|
|
|
|
for key, vals := range r.Header {
|
|
|
|
for _, val := range vals {
|
|
|
|
w.Header().Add(key, val)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
w.WriteHeader(r.StatusCode)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (h Handler) exists(path string) bool {
|
|
|
|
if _, err := os.Stat(h.Root + path); err == nil {
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
|
|
|
|
// buildEnv returns a set of CGI environment variables for the request.
|
|
|
|
func (h Handler) buildEnv(r *http.Request, rule Rule, fpath string) (map[string]string, error) {
|
|
|
|
var env map[string]string
|
|
|
|
|
|
|
|
// Get absolute path of requested resource
|
2017-01-17 12:34:17 -05:00
|
|
|
absPath := filepath.Join(rule.Root, fpath)
|
2016-06-05 23:39:23 -05:00
|
|
|
|
|
|
|
// Separate remote IP and port; more lenient than net.SplitHostPort
|
|
|
|
var ip, port string
|
|
|
|
if idx := strings.LastIndex(r.RemoteAddr, ":"); idx > -1 {
|
|
|
|
ip = r.RemoteAddr[:idx]
|
|
|
|
port = r.RemoteAddr[idx+1:]
|
|
|
|
} else {
|
|
|
|
ip = r.RemoteAddr
|
|
|
|
}
|
|
|
|
|
|
|
|
// Remove [] from IPv6 addresses
|
|
|
|
ip = strings.Replace(ip, "[", "", 1)
|
|
|
|
ip = strings.Replace(ip, "]", "", 1)
|
|
|
|
|
|
|
|
// Split path in preparation for env variables.
|
|
|
|
// Previous rule.canSplit checks ensure this can never be -1.
|
|
|
|
splitPos := rule.splitPos(fpath)
|
|
|
|
|
|
|
|
// Request has the extension; path was split successfully
|
|
|
|
docURI := fpath[:splitPos+len(rule.SplitPath)]
|
|
|
|
pathInfo := fpath[splitPos+len(rule.SplitPath):]
|
|
|
|
scriptName := fpath
|
|
|
|
scriptFilename := absPath
|
|
|
|
|
|
|
|
// Strip PATH_INFO from SCRIPT_NAME
|
|
|
|
scriptName = strings.TrimSuffix(scriptName, pathInfo)
|
|
|
|
|
2017-09-01 23:15:53 -05:00
|
|
|
// Add vhost path prefix to scriptName. Otherwise, some PHP software will
|
|
|
|
// have difficulty discovering its URL.
|
|
|
|
pathPrefix, _ := r.Context().Value(caddy.CtxKey("path_prefix")).(string)
|
|
|
|
scriptName = path.Join(pathPrefix, scriptName)
|
|
|
|
|
httpserver/all: Clean up and standardize request URL handling (#1633)
* httpserver/all: Clean up and standardize request URL handling
The HTTP server now always creates a context value on the request which
is a copy of the request's URL struct. It should not be modified by
middlewares, but it is safe to get the value out of the request and make
changes to it locally-scoped. Thus, the value in the context always
stores the original request URL information as it was received. Any
rewrites that happen will be to the request's URL field directly.
The HTTP server no longer cleans /sanitizes the request URL. It made too
many strong assumptions and ended up making a lot of middleware more
complicated, including upstream proxying (and fastcgi). To alleviate
this complexity, we no longer change the request URL. Middlewares are
responsible to access the disk safely by using http.Dir or, if not
actually opening files, they can use httpserver.SafePath().
I'm hoping this will address issues with #1624, #1584, #1582, and others.
* staticfiles: Fix test on Windows
@abiosoft: I still can't figure out exactly what this is for. 😅
* Use (potentially) changed URL for browse redirects, as before
* Use filepath.ToSlash, clean up a couple proxy test cases
* Oops, fix variable name
2017-05-02 00:11:10 -05:00
|
|
|
// Get the request URI from context. The context stores the original URI in case
|
|
|
|
// it was changed by a middleware such as rewrite. By default, we pass the
|
|
|
|
// original URI in as the value of REQUEST_URI (the user can overwrite this
|
|
|
|
// if desired). Most PHP apps seem to want the original URI. Besides, this is
|
|
|
|
// how nginx defaults: http://stackoverflow.com/a/12485156/1048862
|
|
|
|
reqURL, _ := r.Context().Value(httpserver.OriginalURLCtxKey).(url.URL)
|
2016-06-05 23:39:23 -05:00
|
|
|
|
httpserver/all: Clean up and standardize request URL handling (#1633)
* httpserver/all: Clean up and standardize request URL handling
The HTTP server now always creates a context value on the request which
is a copy of the request's URL struct. It should not be modified by
middlewares, but it is safe to get the value out of the request and make
changes to it locally-scoped. Thus, the value in the context always
stores the original request URL information as it was received. Any
rewrites that happen will be to the request's URL field directly.
The HTTP server no longer cleans /sanitizes the request URL. It made too
many strong assumptions and ended up making a lot of middleware more
complicated, including upstream proxying (and fastcgi). To alleviate
this complexity, we no longer change the request URL. Middlewares are
responsible to access the disk safely by using http.Dir or, if not
actually opening files, they can use httpserver.SafePath().
I'm hoping this will address issues with #1624, #1584, #1582, and others.
* staticfiles: Fix test on Windows
@abiosoft: I still can't figure out exactly what this is for. 😅
* Use (potentially) changed URL for browse redirects, as before
* Use filepath.ToSlash, clean up a couple proxy test cases
* Oops, fix variable name
2017-05-02 00:11:10 -05:00
|
|
|
// Retrieve name of remote user that was set by some downstream middleware such as basicauth.
|
|
|
|
remoteUser, _ := r.Context().Value(httpserver.RemoteUserCtxKey).(string)
|
2017-02-17 17:37:58 -05:00
|
|
|
|
2016-06-05 23:39:23 -05:00
|
|
|
// Some variables are unused but cleared explicitly to prevent
|
|
|
|
// the parent environment from interfering.
|
|
|
|
env = map[string]string{
|
|
|
|
// Variables defined in CGI 1.1 spec
|
|
|
|
"AUTH_TYPE": "", // Not used
|
|
|
|
"CONTENT_LENGTH": r.Header.Get("Content-Length"),
|
|
|
|
"CONTENT_TYPE": r.Header.Get("Content-Type"),
|
|
|
|
"GATEWAY_INTERFACE": "CGI/1.1",
|
|
|
|
"PATH_INFO": pathInfo,
|
|
|
|
"QUERY_STRING": r.URL.RawQuery,
|
|
|
|
"REMOTE_ADDR": ip,
|
|
|
|
"REMOTE_HOST": ip, // For speed, remote host lookups disabled
|
|
|
|
"REMOTE_PORT": port,
|
|
|
|
"REMOTE_IDENT": "", // Not used
|
2017-02-17 17:37:58 -05:00
|
|
|
"REMOTE_USER": remoteUser,
|
2016-06-05 23:39:23 -05:00
|
|
|
"REQUEST_METHOD": r.Method,
|
|
|
|
"SERVER_NAME": h.ServerName,
|
|
|
|
"SERVER_PORT": h.ServerPort,
|
|
|
|
"SERVER_PROTOCOL": r.Proto,
|
|
|
|
"SERVER_SOFTWARE": h.SoftwareName + "/" + h.SoftwareVersion,
|
|
|
|
|
|
|
|
// Other variables
|
2017-01-17 12:34:17 -05:00
|
|
|
"DOCUMENT_ROOT": rule.Root,
|
2016-06-05 23:39:23 -05:00
|
|
|
"DOCUMENT_URI": docURI,
|
|
|
|
"HTTP_HOST": r.Host, // added here, since not always part of headers
|
httpserver/all: Clean up and standardize request URL handling (#1633)
* httpserver/all: Clean up and standardize request URL handling
The HTTP server now always creates a context value on the request which
is a copy of the request's URL struct. It should not be modified by
middlewares, but it is safe to get the value out of the request and make
changes to it locally-scoped. Thus, the value in the context always
stores the original request URL information as it was received. Any
rewrites that happen will be to the request's URL field directly.
The HTTP server no longer cleans /sanitizes the request URL. It made too
many strong assumptions and ended up making a lot of middleware more
complicated, including upstream proxying (and fastcgi). To alleviate
this complexity, we no longer change the request URL. Middlewares are
responsible to access the disk safely by using http.Dir or, if not
actually opening files, they can use httpserver.SafePath().
I'm hoping this will address issues with #1624, #1584, #1582, and others.
* staticfiles: Fix test on Windows
@abiosoft: I still can't figure out exactly what this is for. 😅
* Use (potentially) changed URL for browse redirects, as before
* Use filepath.ToSlash, clean up a couple proxy test cases
* Oops, fix variable name
2017-05-02 00:11:10 -05:00
|
|
|
"REQUEST_URI": reqURL.RequestURI(),
|
2016-06-05 23:39:23 -05:00
|
|
|
"SCRIPT_FILENAME": scriptFilename,
|
|
|
|
"SCRIPT_NAME": scriptName,
|
|
|
|
}
|
|
|
|
|
httpserver/all: Clean up and standardize request URL handling (#1633)
* httpserver/all: Clean up and standardize request URL handling
The HTTP server now always creates a context value on the request which
is a copy of the request's URL struct. It should not be modified by
middlewares, but it is safe to get the value out of the request and make
changes to it locally-scoped. Thus, the value in the context always
stores the original request URL information as it was received. Any
rewrites that happen will be to the request's URL field directly.
The HTTP server no longer cleans /sanitizes the request URL. It made too
many strong assumptions and ended up making a lot of middleware more
complicated, including upstream proxying (and fastcgi). To alleviate
this complexity, we no longer change the request URL. Middlewares are
responsible to access the disk safely by using http.Dir or, if not
actually opening files, they can use httpserver.SafePath().
I'm hoping this will address issues with #1624, #1584, #1582, and others.
* staticfiles: Fix test on Windows
@abiosoft: I still can't figure out exactly what this is for. 😅
* Use (potentially) changed URL for browse redirects, as before
* Use filepath.ToSlash, clean up a couple proxy test cases
* Oops, fix variable name
2017-05-02 00:11:10 -05:00
|
|
|
// compliance with the CGI specification requires that
|
|
|
|
// PATH_TRANSLATED should only exist if PATH_INFO is defined.
|
2016-06-05 23:39:23 -05:00
|
|
|
// Info: https://www.ietf.org/rfc/rfc3875 Page 14
|
|
|
|
if env["PATH_INFO"] != "" {
|
2017-01-17 12:34:17 -05:00
|
|
|
env["PATH_TRANSLATED"] = filepath.Join(rule.Root, pathInfo) // Info: http://www.oreilly.com/openbook/cgi/ch02_04.html
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// Some web apps rely on knowing HTTPS or not
|
|
|
|
if r.TLS != nil {
|
|
|
|
env["HTTPS"] = "on"
|
|
|
|
}
|
|
|
|
|
httpserver/all: Clean up and standardize request URL handling (#1633)
* httpserver/all: Clean up and standardize request URL handling
The HTTP server now always creates a context value on the request which
is a copy of the request's URL struct. It should not be modified by
middlewares, but it is safe to get the value out of the request and make
changes to it locally-scoped. Thus, the value in the context always
stores the original request URL information as it was received. Any
rewrites that happen will be to the request's URL field directly.
The HTTP server no longer cleans /sanitizes the request URL. It made too
many strong assumptions and ended up making a lot of middleware more
complicated, including upstream proxying (and fastcgi). To alleviate
this complexity, we no longer change the request URL. Middlewares are
responsible to access the disk safely by using http.Dir or, if not
actually opening files, they can use httpserver.SafePath().
I'm hoping this will address issues with #1624, #1584, #1582, and others.
* staticfiles: Fix test on Windows
@abiosoft: I still can't figure out exactly what this is for. 😅
* Use (potentially) changed URL for browse redirects, as before
* Use filepath.ToSlash, clean up a couple proxy test cases
* Oops, fix variable name
2017-05-02 00:11:10 -05:00
|
|
|
// Add env variables from config (with support for placeholders in values)
|
2016-06-29 07:41:52 -05:00
|
|
|
replacer := httpserver.NewReplacer(r, nil, "")
|
2016-06-05 23:39:23 -05:00
|
|
|
for _, envVar := range rule.EnvVars {
|
2016-06-29 07:41:52 -05:00
|
|
|
env[envVar[0]] = replacer.Replace(envVar[1])
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
|
2017-03-11 16:59:47 -05:00
|
|
|
// Add all HTTP headers to env variables
|
2016-06-05 23:39:23 -05:00
|
|
|
for field, val := range r.Header {
|
|
|
|
header := strings.ToUpper(field)
|
|
|
|
header = headerNameReplacer.Replace(header)
|
|
|
|
env["HTTP_"+header] = strings.Join(val, ", ")
|
|
|
|
}
|
|
|
|
return env, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Rule represents a FastCGI handling rule.
|
2016-09-27 19:12:22 -05:00
|
|
|
// It is parsed from the fastcgi directive in the Caddyfile, see setup.go.
|
2016-06-05 23:39:23 -05:00
|
|
|
type Rule struct {
|
|
|
|
// The base path to match. Required.
|
|
|
|
Path string
|
|
|
|
|
2017-07-18 13:52:53 -05:00
|
|
|
// upstream load balancer
|
|
|
|
balancer
|
2016-06-05 23:39:23 -05:00
|
|
|
|
|
|
|
// Always process files with this extension with fastcgi.
|
|
|
|
Ext string
|
|
|
|
|
2017-01-17 12:34:17 -05:00
|
|
|
// Use this directory as the fastcgi root directory. Defaults to the root
|
|
|
|
// directory of the parent virtual host.
|
|
|
|
Root string
|
|
|
|
|
2016-06-05 23:39:23 -05:00
|
|
|
// The path in the URL will be split into two, with the first piece ending
|
|
|
|
// with the value of SplitPath. The first piece will be assumed as the
|
|
|
|
// actual resource (CGI script) name, and the second piece will be set to
|
|
|
|
// PATH_INFO for the CGI script to use.
|
|
|
|
SplitPath string
|
|
|
|
|
|
|
|
// If the URL ends with '/' (which indicates a directory), these index
|
|
|
|
// files will be tried instead.
|
|
|
|
IndexFiles []string
|
|
|
|
|
|
|
|
// Environment Variables
|
|
|
|
EnvVars [][2]string
|
|
|
|
|
|
|
|
// Ignored paths
|
|
|
|
IgnoredSubPaths []string
|
2016-09-24 00:29:23 -05:00
|
|
|
|
2017-07-18 13:52:53 -05:00
|
|
|
// The duration used to set a deadline when connecting to an upstream.
|
|
|
|
ConnectTimeout time.Duration
|
|
|
|
|
2016-11-19 11:05:29 -05:00
|
|
|
// The duration used to set a deadline when reading from the FastCGI server.
|
|
|
|
ReadTimeout time.Duration
|
|
|
|
|
2016-11-29 21:26:51 -05:00
|
|
|
// The duration used to set a deadline when sending to the FastCGI server.
|
|
|
|
SendTimeout time.Duration
|
2017-07-18 13:52:53 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// balancer is a fastcgi upstream load balancer.
|
|
|
|
type balancer interface {
|
|
|
|
// Address picks an upstream address from the
|
|
|
|
// underlying load balancer.
|
2017-10-03 08:17:54 -05:00
|
|
|
Address() (string, error)
|
2017-07-18 13:52:53 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// roundRobin is a round robin balancer for fastcgi upstreams.
|
|
|
|
type roundRobin struct {
|
2017-07-28 11:01:52 -05:00
|
|
|
// Known Go bug: https://golang.org/pkg/sync/atomic/#pkg-note-BUG
|
|
|
|
// must be first field for 64 bit alignment
|
|
|
|
// on x86 and arm.
|
2017-07-18 13:52:53 -05:00
|
|
|
index int64
|
2017-07-28 11:01:52 -05:00
|
|
|
addresses []string
|
2017-07-18 13:52:53 -05:00
|
|
|
}
|
2016-11-29 21:26:51 -05:00
|
|
|
|
2017-10-03 08:17:54 -05:00
|
|
|
func (r *roundRobin) Address() (string, error) {
|
2017-07-18 13:52:53 -05:00
|
|
|
index := atomic.AddInt64(&r.index, 1) % int64(len(r.addresses))
|
2017-10-03 08:17:54 -05:00
|
|
|
return r.addresses[index], nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// srvResolver is a private interface used to abstract
|
|
|
|
// the DNS resolver. It is mainly used to facilitate testing.
|
|
|
|
type srvResolver interface {
|
|
|
|
LookupSRV(ctx context.Context, service, proto, name string) (string, []*net.SRV, error)
|
|
|
|
}
|
|
|
|
|
|
|
|
// srv is a service locator for fastcgi upstreams
|
|
|
|
type srv struct {
|
|
|
|
resolver srvResolver
|
|
|
|
service string
|
|
|
|
}
|
|
|
|
|
|
|
|
// Address looks up the service and returns the address:port
|
|
|
|
// from first result in resolved list.
|
|
|
|
// No explicit balancing is required because net.LookupSRV
|
|
|
|
// sorts the results by priority and randomizes within priority.
|
|
|
|
func (s *srv) Address() (string, error) {
|
|
|
|
_, addrs, err := s.resolver.LookupSRV(context.Background(), "", "", s.service)
|
|
|
|
if err != nil {
|
|
|
|
return "", err
|
|
|
|
}
|
|
|
|
|
|
|
|
return fmt.Sprintf("%s:%d", strings.TrimRight(addrs[0].Target, "."), addrs[0].Port), nil
|
2016-06-05 23:39:23 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
// canSplit checks if path can split into two based on rule.SplitPath.
|
|
|
|
func (r Rule) canSplit(path string) bool {
|
|
|
|
return r.splitPos(path) >= 0
|
|
|
|
}
|
|
|
|
|
|
|
|
// splitPos returns the index where path should be split
|
|
|
|
// based on rule.SplitPath.
|
|
|
|
func (r Rule) splitPos(path string) int {
|
|
|
|
if httpserver.CaseSensitivePath {
|
|
|
|
return strings.Index(path, r.SplitPath)
|
|
|
|
}
|
|
|
|
return strings.Index(strings.ToLower(path), strings.ToLower(r.SplitPath))
|
|
|
|
}
|
|
|
|
|
|
|
|
// AllowedPath checks if requestPath is not an ignored path.
|
|
|
|
func (r Rule) AllowedPath(requestPath string) bool {
|
|
|
|
for _, ignoredSubPath := range r.IgnoredSubPaths {
|
|
|
|
if httpserver.Path(path.Clean(requestPath)).Matches(path.Join(r.Path, ignoredSubPath)) {
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return true
|
|
|
|
}
|
|
|
|
|
|
|
|
var (
|
|
|
|
headerNameReplacer = strings.NewReplacer(" ", "_", "-", "_")
|
|
|
|
// ErrIndexMissingSplit describes an index configuration error.
|
|
|
|
ErrIndexMissingSplit = errors.New("configured index file(s) must include split value")
|
|
|
|
)
|
|
|
|
|
|
|
|
// LogError is a non fatal error that allows requests to go through.
|
|
|
|
type LogError string
|
|
|
|
|
|
|
|
// Error satisfies error interface.
|
|
|
|
func (l LogError) Error() string {
|
|
|
|
return string(l)
|
|
|
|
}
|