a31bbd7ff8
* fix(markdown): don’t generate mdast html nodes `html` nodes from mdast are converted to `raw` hast nodes. These nodes are then not processed by proper rehype plugins. Typically if a remark plugin generates `html` nodes, this indicates it should have actually been a rehype plugin. This changes the remark plugins that generate `html` nodes into rehype nodes. These were `remarkPrism` and `remarkShiki`. Closes #9909 * Apply suggestions from code review * refactor(mdx): move user defined rehype plugins after syntax highlighting * fix(mdx): fix issue in mdx rehype plugin ordering * docs: explain why html/raw nodes are avoided in changeset This also includes some hints on what users could do to upgrade of they rely on these nodes. * Fix MDX rehype plugin ordering * refactor(remark): restore remarkPrism and remarkShiki They aren’t used anymore, but removing would be a breaking change. * chore: mark deprecated * Apply suggestions from code review Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> * Update .changeset/thirty-beds-smoke.md Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> --------- Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com> Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca> |
||
---|---|---|
.. | ||
index.ts | ||
plugins.ts | ||
README.md | ||
recma-inject-import-meta-env.ts | ||
rehype-apply-frontmatter-export.ts | ||
rehype-collect-headings.ts | ||
rehype-meta-string.ts | ||
rehype-optimize-static.ts | ||
remark-images-to-component.ts | ||
utils.ts |
Internal documentation
rehype-optimize-static
The rehype-optimize-static
plugin helps optimize the intermediate hast
when processing MDX, collapsing static subtrees of the hast
as a "static string"
in the final JSX output. Here's a "before" and "after" result:
Before:
function _createMdxContent() {
return (
<>
<h1>My MDX Content</h1>
<pre>
<code class="language-js">
<span class="token function">console</span>
<span class="token punctuation">.</span>
<span class="token function">log</span>
<span class="token punctuation">(</span>
<span class="token string">'hello world'</span>
<span class="token punctuation">)</span>
</code>
</pre>
</>
);
}
After:
function _createMdxContent() {
return (
<>
<h1>My MDX Content</h1>
<pre set:html="<code class=...</code>"></pre>
</>
);
}
NOTE: If one of the nodes in
pre
is MDX, the optimization will not be applied topre
, but could be applied to the inner MDX node if its children are static.
This results in fewer JSX nodes, less compiled JS output, and less parsed AST, which results in faster Rollup builds and runtime rendering.
To achieve this, we use an algorithm to detect hast
subtrees that are entirely static (containing no JSX) to be inlined as set:html
to the root of the subtree.
The next section explains the algorithm, which you can follow along by pairing with the source code. To analyze the hast
, you can paste the MDX code into https://mdxjs.com/playground.
How it works
Two variables:
allPossibleElements
: A set of subtree roots where we can add a newset:html
property with its children as value.elementStack
: The stack of elements (that could be subtree roots) while traversing thehast
(node ancestors).
Flow:
- Walk the
hast
tree. - For each
node
we enter, if thenode
is static (type
iselement
ormdxJsxFlowElement
), record inallPossibleElements
and push toelementStack
.- Q: Why do we record
mdxJsxFlowElement
, it's MDX?
A: Because we're looking for nodes whose children are static. The node itself doesn't need to be static. - Q: Are we sure this is the subtree root node in
allPossibleElements
?
A: No, but we'll clear that up later in step 3.
- Q: Why do we record
- For each
node
we leave, pop fromelementStack
. If thenode
's parent is inallPossibleElements
, we also remove thenode
fromallPossibleElements
.- Q: Why do we check for the node's parent?
A: Checking for the node's parent allows us to identify a subtree root. When we enter a subtree likeC -> D -> E
, we leave in reverse:E -> D -> C
. When we leaveE
, we see that it's parentD
exists, so we removeE
. When we leaveD
, we seeC
exists, so we removeD
. When we leaveC
, we see that its parent doesn't exist, so we keepC
, a subtree root.
- Q: Why do we check for the node's parent?
- (Returning to the code written for step 2's
node
enter handling) We also need to handle the case where we find non-static elements. If found, we remove all the elements inelementStack
fromallPossibleElements
. This happens before the code in step 2.- Q: Why?
A: Because if thenode
isn't static, that means all its ancestors (elementStack
) have non-static children. So, the ancestors couldn't be a subtree root to be optimized anymore. - Q: Why before step 2's
node
enter handling?
A: If we find a non-staticnode
, thenode
should still be considered inallPossibleElements
as its children could be static.
- Q: Why?
- Walk done. This leaves us with
allPossibleElements
containing only subtree roots that can be optimized. - Add the
set:html
property to thehast
node, and remove its children. - 🎉 The rest of the MDX pipeline will do its thing and generate the desired JSX like above.
Extra
MDX custom components
Astro's MDX implementation supports specifying export const components
in the MDX file to render some HTML elements as Astro components or framework components. rehype-optimize-static
also needs to parse this JS to recognize some elements as non-static.
Further optimizations
In How it works step 4,
we remove all the elements in
elementStack
fromallPossibleElements
We can further optimize this by then also emptying the elementStack
. This ensures that if we run this same flow for a deeper node in the tree, we don't remove the already-removed nodes from allPossibleElements
.
While this breaks the concept of elementStack
, it doesn't matter as the elementStack
array pop in the "leave" handler (in step 3) would become a no-op.
Example elementStack
value during walking phase:
Enter: A
Enter: A, B
Enter: A, B, C
(Non-static node found): <empty>
Enter: D
Enter: D, E
Leave: D
Leave: <empty>
Leave: <empty>
Leave: <empty>
Leave: <empty>