mirror of https://github.com/withastro/astro.git synced 2024-12-23 21:53:55 -05:00

History

Eric Mika 0bf2cca5d7 Filter out Svelte's unknown class prop console warnings (#7291 ) * Filter out Svelte's unexpected class prop console warnings Astro's hydration code passes a `class` prop to Svelte components, inducing Svelte to log a warning about an unknown prop. Preempting this by exporting a `class` prop from the Svelte component isn't a viable workaround since `class` is a reserved identifier in JS. This PR implements the console-filtering workaround suggested by @HiDeoo in #5665, borrowing the `useConsoleFilter` approach from the [preact integration](`a1c0cbe604/packages/integrations/preact/src/server.ts (L72-L94)`). It would probably be better to generalize console filtering so it could be shared across multiple integrations. Ideally there would be a way to handle this in Svelte, but as was pointed out in the issue thread even they resort to [similar cringe-inducing hackery](https://github.com/sveltejs/kit/blob/master/packages/kit/src/runtime/client/client.js#L1974-L1996) in sveltekit. * Only filter Svelte console warnings in dev builds * Add changeset * Fix lint error. --------- Co-authored-by: bluwy <bjornlu.dev@gmail.com> Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>		2023-08-15 17:31:01 -05:00
..
big-elephants-drive.md	Filter out Svelte's unknown class prop console warnings (#7291 )	2023-08-15 17:31:01 -05:00
config.json	Fix changeset publish (#6923 )	2023-04-27 22:55:48 +08:00
README.md

README.md

Changesets

Hello and welcome! This folder has been automatically generated by @changesets/cli, a build tool that works with multi-package repos, or single-package repos to help you version and publish your code. You can find the full documentation for it in our repository

We have a quick list of common questions to get you started engaging with this project in our documentation