Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-01-06 22:10:10 -05:00
Code Issues Activity

fix a deprecated method in react integration using SSR: renderToStaticNodeStream (#10893)

Browse source 
* deprecated method renderToStaticNodeStream

* Create twelve-bulldogs-raise.md

---------

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
This commit is contained in:
Gabriele Angrisani 2024-04-30 14:01:21 +02:00 committed by GitHub
parent 36bb3b6025
commit fd7a9ed337
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 33 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/twelve-bulldogs-raise.md Normal file
View file

@ -0,0 +1,5 @@
---
"@astrojs/react": patch
---
Removes using deprecated `ReactDOMServer.renderToStaticNodeStream` API

30
packages/integrations/react/server.js
View file

@ -106,19 +106,11 @@ async function renderToStaticMarkup(Component, props, { default: children, ...sl
identifierPrefix: prefix, identifierPrefix: prefix,
}; };
let html; let html;
if (metadata?.hydrate) {
if ('renderToReadableStream' in ReactDOM) { if ('renderToReadableStream' in ReactDOM) {
html = await renderToReadableStreamAsync(vnode, renderOptions); html = await renderToReadableStreamAsync(vnode, renderOptions);
} else { } else {
html = await renderToPipeableStreamAsync(vnode, renderOptions); html = await renderToPipeableStreamAsync(vnode, renderOptions);
} }
} else {
if ('renderToReadableStream' in ReactDOM) {
html = await renderToReadableStreamAsync(vnode, renderOptions);
} else {
html = await renderToStaticNodeStreamAsync(vnode, renderOptions);
}
}
return { html, attrs }; return { html, attrs };
} }
@ -150,28 +142,6 @@ async function renderToPipeableStreamAsync(vnode, options) {
}); });
} }
async function renderToStaticNodeStreamAsync(vnode, options) {
const Writable = await getNodeWritable();
let html = '';
return new Promise((resolve, reject) => {
let stream = ReactDOM.renderToStaticNodeStream(vnode, options);
stream.on('error', (err) => {
reject(err);
});
stream.pipe(
new Writable({
write(chunk, _encoding, callback) {
html += chunk.toString('utf-8');
callback();
},
destroy() {
resolve(html);
},
})
);
});
}
/** /**
* Use a while loop instead of "for await" due to cloudflare and Vercel Edge issues * Use a while loop instead of "for await" due to cloudflare and Vercel Edge issues
* See https://github.com/facebook/react/issues/24169 * See https://github.com/facebook/react/issues/24169