Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-16 21:46:22 -05:00
Code Issues Activity

fix: output 404.astro to 404.html (#1949)

Browse source 
* fix: output 404.astro to 404.html

* chore: revert example change

* fix: update status code to only match 404
This commit is contained in:
Nate Moore 2021-11-22 12:06:15 -06:00 committed by GitHub
parent 69affc5929
commit fc5f416382
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/twenty-hounds-approve.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fix regression with `astro build` 404.astro output

14
packages/astro/src/vite-plugin-build-html/index.ts
View file

@ -21,7 +21,7 @@ const ASTRO_PAGE_PREFIX = '@astro-page';
const ASTRO_SCRIPT_PREFIX = '@astro-script';
const ASTRO_EMPTY = '@astro-empty';
const STATUS_CODE_RE = /^404$/;
const tagsWithSrcSet = new Set(['img', 'source']);
const isAstroInjectedLink = (node: parse5.Element) => isStylesheetLink(node) && getAttribute(node, 'data-astro-injected') === '';
@ -424,7 +424,17 @@ export function rollupPluginAstroBuildHTML(options: PluginOptions): VitePlugin {
}
const outHTML = parse5.serialize(document);
const outPath = npath.posix.join(pathname.substr(1), 'index.html');
const name = pathname.substr(1);
let outPath: string;
// Output directly to 404.html rather than 400/index.html
// Supports any other status codes, too
if (name.match(STATUS_CODE_RE)) {
outPath = npath.posix.join(`${name}.html`)
} else {
outPath = npath.posix.join(name, 'index.html')
}
this.emitFile({
fileName: outPath,
source: outHTML,