Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-30 22:03:56 -05:00
Code Issues Activity

fix: correctly check isOnline with port (#12706)

Browse source
This commit is contained in:
Matt Kane 2024-12-10 20:00:58 +00:00 committed by GitHub
parent 316959355c
commit f6c4214042
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/wild-ducks-decide.md Normal file
View file

@ -0,0 +1,5 @@
---
'@astrojs/upgrade': patch
---
Fixes a bug that caused registry URLs that specify a port to be incorrectly detected as offline.

4
packages/upgrade/src/actions/verify.ts
View file

@ -43,8 +43,8 @@ export async function verify(
} }
function isOnline(registry: string): Promise<boolean> { function isOnline(registry: string): Promise<boolean> {
const { host } = new URL(registry); const { hostname } = new URL(registry);
return dns.lookup(host).then( return dns.lookup(hostname).then(
() => true, () => true,
() => false, () => false,
); );