Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-16 21:46:22 -05:00
Code Issues Activity

view transition's form handling honors default prevention (#9486)

Browse source 
* add missing check to honor prevented default

* added changeset

* Update .changeset/fresh-games-confess.md

Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>

---------

Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
This commit is contained in:
Martin Trapp 2023-12-20 14:44:48 +01:00 committed by GitHub
parent 5062d27a18
commit f6714f677c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/fresh-games-confess.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fixes View Transition's form submission prevention, allowing `preventDefault` to be used.

2
packages/astro/components/ViewTransitions.astro
View file

@ -94,7 +94,7 @@ const { fallback = 'animate' } = Astro.props;
document.addEventListener('submit', (ev) => {
let el = ev.target as HTMLElement;
if (el.tagName !== 'FORM' || isReloadEl(el)) {
if (el.tagName !== 'FORM' || ev.defaultPrevented || isReloadEl(el)) {
return;
}
const form = el as HTMLFormElement;