Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-23 21:53:55 -05:00
Code Issues Activity

Revert "Revert "View Transition: swap attributes of document's root element (#8206)""

Browse source 
This reverts commit e942855329.
This commit is contained in:
Matthew Phillips 2023-08-24 10:23:44 -04:00
parent e942855329
commit ebaccf8c1a
5 changed files with 69 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
packages/astro/components/ViewTransitions.astro
View file

@ -136,6 +136,18 @@ const { fallback = 'animate' } = Astro.props as Props;
// Remove them before swapping.
doc.querySelectorAll('head noscript').forEach((el) => el.remove());
// swap attributes of the html element
// - delete all attributes from the current document
// - insert all attributes from doc
// - reinsert all original attributes that are named 'data-astro-*'
const html = document.documentElement;
const astro = [...html.attributes].filter(
({ name }) => (html.removeAttribute(name), name.startsWith('data-astro-'))
);
[...doc.documentElement.attributes, ...astro].forEach(({ name, value }) =>
html.setAttribute(name, value)
);
// Swap head
for (const el of Array.from(document.head.children)) {
const newEl = persistedHeadElement(el);

17
packages/astro/e2e/fixtures/view-transitions/src/components/AttributedLayout.astro Normal file
View file

@ -0,0 +1,17 @@
---
import { ViewTransitions } from 'astro:transitions';
import { HTMLAttributes } from 'astro/types';
interface Props extends HTMLAttributes<'html'> {}
---
<html {...Astro.props}>
<head>
<title>Testing</title>
<ViewTransitions />
</head>
<body>
<main transition:animate="slide">
<slot />
</main>
</body>
</html>

11
packages/astro/e2e/fixtures/view-transitions/src/pages/other-attributes.astro Normal file
View file

@ -0,0 +1,11 @@
---
import AttributeLayout from '../components/AttributedLayout.astro';
---
<AttributeLayout
lang="es"
style="background-color: green"
data-other-name="value"
data-astro-fake="value"
data-astro-transition="downward">
<p id="heading">Page with other attributes</p>
</AttributeLayout>

7
packages/astro/e2e/fixtures/view-transitions/src/pages/some-attributes.astro Normal file
View file

@ -0,0 +1,7 @@
---
import AttributedLayout from '../components/AttributedLayout.astro';
---
<AttributedLayout lang="en" class="ugly">
<p id="heading">Page with some attributes</p>
<a id="click-other-attributes" href="/other-attributes">Other attributes</a>
</AttributedLayout>

22
packages/astro/e2e/view-transitions.test.js
View file

@ -397,3 +397,25 @@ test.describe('View Transitions', () => {
).toEqual(1);
});
});
test('Navigation also swaps the attributes of the document root', async ({ page, astro }) => {
page.on('console', (msg) => console.log(msg.text()));
await page.goto(astro.resolveUrl('/some-attributes'));
let p = page.locator('#heading');
await expect(p, 'should have content').toHaveText('Page with some attributes');
let h = page.locator('html');
await expect(h, 'should have content').toHaveAttribute('lang', 'en');
await page.click('#click-other-attributes');
p = page.locator('#heading');
await expect(p, 'should have content').toHaveText('Page with other attributes');
h = page.locator('html');
await expect(h, 'should have content').toHaveAttribute('lang', 'es');
await expect(h, 'should have content').toHaveAttribute('style', 'background-color: green');
await expect(h, 'should have content').toHaveAttribute('data-other-name', 'value');
await expect(h, 'should have content').toHaveAttribute('data-astro-fake', 'value');
await expect(h, 'should have content').toHaveAttribute('data-astro-transition', 'forward');
await expect(h, 'should be absent').not.toHaveAttribute('class', /.*/);
});