Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

Add server island route to the front of the route list (#12263)

Browse source 
* Add server island route to the front of the route list

* Add changeset
This commit is contained in:
Luiz Ferraz 2024-10-21 13:13:52 -03:00 • committed by GitHub
parent 388d2375b6
commit e9e8080a81
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 20 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/honest-dots-jump.md Normal file
View file

@ -0,0 +1,5 @@
---
'astro': patch
---
Fixes conflict between server islands and on-demand dynamic routes in the form of `/[...rest]` or `/[paramA]/[paramB]`.

14
packages/astro/e2e/fixtures/server-islands/src/pages/[conflicting]/[dynamicRoute].astro Normal file
View file

@ -0,0 +1,14 @@
---
export const prerender = false;
---
<html>
<head>
<title>Conflicting route</title>
</head>
<body>
This route would conflict with the route generated for server islands.
<br />
This file is here so the tests break if that happens.
</body>
</html>

2
packages/astro/src/core/server-islands/endpoint.ts
View file

@ -44,7 +44,7 @@ export function ensureServerIslandRoute(config: ConfigFields, routeManifest: Man
return;
}
routeManifest.routes.push(getServerIslandRouteData(config));
routeManifest.routes.unshift(getServerIslandRouteData(config));
}
type RenderOptions = {