Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-02-03 22:29:08 -05:00
Code Issues Activity

Investiging a flaky error test (#3613)

Browse source 
* restarting dev server between each error test

* re-enabling the test on Linux CI

* trying separate describe() suites per error test

* narrowed the issue down, disabling for more investigation

* not: removing unrelated whitespace change
This commit is contained in:
Tony Sullivan 2022-06-16 22:09:47 +00:00 • committed by GitHub
parent 9716747879
commit e02097d0b9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 13 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
packages/astro/test/errors.test.js
View file

@ -5,10 +5,6 @@ import * as cheerio from 'cheerio';
describe('Error display', () => { describe('Error display', () => {
if (isWindows) return; if (isWindows) return;
// TODO: Ubuntu CI runs hit a reliability problem with more than one test in this suite.
// Re-enable this suite once that issue is tracked down.
if (isLinux) return;
/** @type {import('./test-utils').Fixture} */ /** @type {import('./test-utils').Fixture} */
let fixture; let fixture;
@ -18,14 +14,24 @@ describe('Error display', () => {
}); });
}); });
describe('Astro', async () => { /**
* TODO: Track down reliability issue
*
* After fixing a syntax error on one page, the dev server hangs on the hmr.js request.
* This is specific to a project that has other framework component errors,
* in this case the fixture has multiple broken pages and components.
*
* The issue could be internal to vite, the hmr.js request triggers connect:dispatcher
* events but vite:load is never actually called.
*/
describe.skip('Astro template syntax', async () => {
let devServer; let devServer;
before(async () => { beforeEach(async () => {
devServer = await fixture.startDevServer(); devServer = await fixture.startDevServer();
}); });
after(async () => { afterEach(async () => {
await devServer.stop(); await devServer.stop();
}); });