Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

fix(node): Safely create requests (#10285)

Browse source 
* fix(node): Wrap request creation in try catch

* chore: changeset
This commit is contained in:
Erika 2024-03-01 11:26:28 +01:00 • committed by GitHub
parent afd41cc28b
commit d5277df5a4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 14 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/perfect-poets-teach.md Normal file
View file

@ -0,0 +1,5 @@
---
"@astrojs/node": patch
---
Fixes an issue where malformed requests could cause the server to error in certain cases.

10
packages/integrations/node/src/serve-app.ts
View file

@ -8,7 +8,15 @@ import type { RequestHandler } from './types.js';
*/
export function createAppHandler(app: NodeApp): RequestHandler {
return async (req, res, next, locals) => {
const request = NodeApp.createRequest(req);
let request;
try {
request = NodeApp.createRequest(req);
} catch (err) {
res.statusCode = 500;
res.end('Internal Server Error');
return;
}
const routeData = app.match(request);
if (routeData) {
const response = await app.render(request, {