Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2025-03-31 23:31:30 -05:00
Code Issues Activity

Generates missing popstate events for Firefox when navigating to hash targets on the same page. (#10679)

Browse source
This commit is contained in:
Martin Trapp 2024-04-04 19:05:10 +02:00 • committed by GitHub
parent d4b88c79b2
commit ca6bb1f31e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 11 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
.changeset/loud-numbers-notice.md Normal file
View file

@ -0,0 +1,5 @@
---
"astro": patch
---
Generates missing popstate events for Firefox when navigating to hash targets on the same page.

7
packages/astro/src/transitions/router.ts
View file

@ -205,7 +205,12 @@ const moveToLocation = (
history.scrollRestoration = 'auto';
const savedState = history.state;
location.href = to.href; // this kills the history state on Firefox
history.state || replaceState(savedState, ''); // this restores the history state
if (!history.state) {
replaceState(savedState, ''); // this restores the history state
if (intraPage){
window.dispatchEvent(new PopStateEvent('popstate' ));
}
}
} else {
if (!scrolledToTop) {
scrollTo({ left: 0, top: 0, behavior: 'instant' });