From c856c729404196900a7386c8426b81e79684a6a9 Mon Sep 17 00:00:00 2001 From: Erika <3019731+Princesseuh@users.noreply.github.com> Date: Thu, 22 Feb 2024 16:41:05 +0100 Subject: [PATCH] fix(errors): Remove duplicate logging of errors (#10197) * fix(errors): Remove duplicate logging of errors * chore: changeset --- .changeset/light-masks-watch.md | 5 +++++ packages/astro/src/vite-plugin-astro-server/response.ts | 5 ++--- 2 files changed, 7 insertions(+), 3 deletions(-) create mode 100644 .changeset/light-masks-watch.md diff --git a/.changeset/light-masks-watch.md b/.changeset/light-masks-watch.md new file mode 100644 index 0000000000..95a3f9c71c --- /dev/null +++ b/.changeset/light-masks-watch.md @@ -0,0 +1,5 @@ +--- +"astro": patch +--- + +Fixes errors being logged twice in some cases diff --git a/packages/astro/src/vite-plugin-astro-server/response.ts b/packages/astro/src/vite-plugin-astro-server/response.ts index 54cf6ef3ab..c6e034aefc 100644 --- a/packages/astro/src/vite-plugin-astro-server/response.ts +++ b/packages/astro/src/vite-plugin-astro-server/response.ts @@ -83,9 +83,8 @@ export async function writeWebResponse(res: http.ServerResponse, webResponse: Re } else { const reader = body.getReader(); res.on('close', () => { - reader.cancel().catch((error: unknown) => { - // eslint-disable-next-line no-console - console.error('An unexpected error occurred in the middle of the stream.', error); + reader.cancel().catch(() => { + // Don't log here, or errors will get logged twice in most cases }); }); while (true) {