Infrastructure/astro
0
Fork 0
mirror of https://github.com/withastro/astro.git synced 2024-12-16 21:46:22 -05:00
Code Issues Activity

fix(vercel): Fix srcset generation not working on Vercel (#10756)

Browse source 
* fix(vercel): Fix `srcset` generation not working on Vercel

* chore: changeset

* fix: remove densities and widths from the HTML attributes

* nit: better changeset

* nit: add formats
This commit is contained in:
Erika 2024-04-12 10:07:27 -04:00 committed by GitHub
parent 17c2bb1aad
commit c75ededdb4
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 12 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
.changeset/nine-radios-peel.md Normal file
View file

@ -0,0 +1,7 @@
---
"@astrojs/vercel": patch
---
Fixes `widths` and `densities` not working when using Vercel's Image Optimization.
Note that you still need to make sure that the widths you're outputting are enabled in [the `imageConfig` property of the Vercel adapter](https://docs.astro.build/en/guides/integrations-guide/vercel/#imagesconfig) in order for these properties to work.

4
packages/integrations/vercel/src/image/build-service.ts
View file

@ -1,7 +1,9 @@
import type { ExternalImageService } from 'astro';
import { isESMImportedImage, sharedValidateOptions } from './shared.js';
import { baseService } from 'astro/assets';
const service: ExternalImageService = {
...baseService,
validateOptions: (options, serviceOptions) =>
sharedValidateOptions(options, serviceOptions.service.config, 'production'),
getHTMLAttributes(options) {
@ -29,7 +31,7 @@ const service: ExternalImageService = {
}
}
const { src, width, height, format, quality, ...attributes } = props;
const { src, width, height, format, quality, densities, widths, formats, ...attributes } = options;
return {
...attributes,

2
packages/integrations/vercel/src/image/shared-dev-service.ts
View file

@ -1,7 +1,9 @@
import type { LocalImageService } from 'astro';
import { baseService } from 'astro/assets';
import { sharedValidateOptions } from './shared.js';
export const baseDevService: Omit<LocalImageService, 'transform'> = {
...baseService,
validateOptions: (options, serviceOptions) =>
sharedValidateOptions(options, serviceOptions.service.config, 'development'),
getURL(options) {